Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make certain arguments optional to allow creation of replicas #136

Merged
merged 14 commits into from
Jun 19, 2022
Merged

Make certain arguments optional to allow creation of replicas #136

merged 14 commits into from
Jun 19, 2022

Conversation

mihaiplesa
Copy link
Contributor

@mihaiplesa mihaiplesa commented Apr 11, 2022 •
edited by nitrocode
Loading

what

  • Make certain arguments optional

why

  • Fix creation of replicas

references

@mihaiplesa mihaiplesa requested review from a team as code owners April 11, 2022 01:16
@mihaiplesa mihaiplesa requested review from a team as code owners April 11, 2022 01:17
bridgecrew[bot]
bridgecrew bot reviewed Apr 11, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Apr 11, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Apr 11, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
bridgecrew[bot]
bridgecrew bot reviewed Apr 11, 2022
View reviewed changes
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 1e0d3d9 - Auto Format - 3 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_46 Fixed /main.tf module.rds_instance.aws_db_instance.default
BC_AWS_LOGGING_28 Fixed /main.tf module.rds_instance.aws_db_instance.default
BC_AWS_IAM_60 Fixed /main.tf module.rds_instance.aws_db_instance.default

@mihaiplesa mihaiplesa changed the title fixed replica db creation fix creation of replica Apr 11, 2022
nitrocode
nitrocode reviewed Apr 27, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Apr 27, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
mihaiplesa and others added 3 commits April 27, 2022 13:08
@mihaiplesa @nitrocode
Update main.tf
4d099ab 
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
@mihaiplesa
edited variable descriptions
ecab1a4
@cloudpossebot
Auto Format
2446a6d
@elkh510
Copy link
Contributor

elkh510 commented May 17, 2022

hi @jamengual @Benbentwo
could you pls merge this one
thank you!

nitrocode
nitrocode reviewed Jun 3, 2022
View reviewed changes
main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jun 3, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jun 3, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jun 3, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jun 3, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode reviewed Jun 3, 2022
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
mihaiplesa and others added 2 commits June 3, 2022 08:37
@mihaiplesa @nitrocode
Update main.tf
0b7f9ce 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@mihaiplesa @nitrocode
Apply suggestions from code review
d7ead01 
Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com>
@mihaiplesa mihaiplesa requested a review from nitrocode June 3, 2022 13:39
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Jun 14, 2022
@nitrocode nitrocode changed the title fix creation of replica Make certain arguments null to allow read replicas to work Jun 18, 2022
@nitrocode nitrocode changed the title Make certain arguments null to allow read replicas to work Make certain arguments optional to allow creation of replicas Jun 18, 2022
@nitrocode
Copy link
Member

/test test/bats

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode merged commit b9ae8e7 into cloudposse:master Jun 19, 2022
@mihaiplesa mihaiplesa deleted the mplesa-replicate-db-fixes branch June 19, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridgecrew bridgecrew[bot] bridgecrew[bot] left review comments

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual Awaiting requested review from jamengual jamengual was automatically assigned from cloudposse/contributors

@Benbentwo Benbentwo Awaiting requested review from Benbentwo Benbentwo was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflicting parameters when creating replica
4 participants
@mihaiplesa @elkh510 @nitrocode @cloudpossebot