Skip to content

add subnet_group_id optional override for subnet group id #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add subnet_group_id optional override for subnet group id #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f1aa78
add subnet_group_id optional override for subnet group id
Quixotical Oct 17, 2025
094ac3a
apply PR feedback, remove unnecessary variable
Quixotical Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions modules/dms-replication-instance/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
locals {
enabled = module.this.enabled
enabled = module.this.enabled
create_subnet_group = local.enabled && var.subnet_group_id == null
}

resource "aws_dms_replication_instance" "default" {
Expand All @@ -18,14 +19,14 @@ resource "aws_dms_replication_instance" "default" {
preferred_maintenance_window = var.preferred_maintenance_window
publicly_accessible = var.publicly_accessible
replication_instance_class = var.replication_instance_class
replication_subnet_group_id = join("", aws_dms_replication_subnet_group.default[*].id)
replication_subnet_group_id = coalesce(var.subnet_group_id, join("", aws_dms_replication_subnet_group.default[*].id))
vpc_security_group_ids = var.vpc_security_group_ids

tags = module.this.tags
}

resource "aws_dms_replication_subnet_group" "default" {
count = local.enabled ? 1 : 0
count = local.create_subnet_group ? 1 : 0

replication_subnet_group_id = module.this.id
replication_subnet_group_description = format("%s DMS replication subnet group", module.this.id)
Expand Down
6 changes: 6 additions & 0 deletions modules/dms-replication-instance/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,9 @@ variable "subnet_ids" {
type = list(string)
description = "List of the EC2 subnet IDs for the replication subnet group"
}

variable "subnet_group_id" {
type = string
description = "The human readable ID of the replication subnet group to be used with the replication instance"
default = null
}