add subnet_group_id optional override for subnet group id #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quixotical
force-pushed
the
add-subnet-group-override-name
branch
from
c1e7b84 to
9f1aa78
Compare
oycyc
reviewed
Oct 18, 2025
|
|
||
| resource "aws_dms_replication_subnet_group" "default" { | ||
| count = local.enabled ? 1 : 0 | ||
| count = local.enabled && var.create_subnet_group ? 1 : 0 |
There was a problem hiding this comment.
Would it be better if this checks if a var.subnet_group_id is passed in? This way, if a consumer passes in a subnet group, the module knows not to create a subnet group.
There was a problem hiding this comment.
yeah that's a great idea, I'll push that change now, thanks for the input!
There was a problem hiding this comment.
alrighty, change is applied, let me know what you think 😄
|
/terratest |
oycyc
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
NOw if you provide a variable
subnet_group_idto the terraform module, it will use that as the name of the subnet group that you create. This will allow multiple dms replication instances to use the same DMS subnet group.why
We need this functionality because AWS has limits on the number of DMS subnet groups that you can create. (It's 60) we have a very large volume of replications required in our system, and so we will hit that limit. We can always ask to have it continually increased, but all of these replication instances will be using the exact same subnet configuration and it's redundant to keep making the same configuration over and over again, and asking AWS to increase their limits.
references
https://docs.aws.amazon.com/dms/latest/userguide/CHAP_Limits.html#CHAP_Limits.Limits