Skip to content

Remove Cf Role by Username #4172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Mar 30, 2020
Merged

Remove Cf Role by Username #4172

merged 31 commits into from
Mar 30, 2020

Conversation

@richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Mar 17, 2020 •
edited
Loading

#4171 Details

  • Fixes Allow org managers to add users outside of org #4103
  • Added new stepper that adds roles by username
  • Stepper can handle multiple users
  • New stepper reachable via the org or space users list
  • Stepper modify and confirm steps are same as usual manage user roles stepper
    • Only difference is existing roles are not shown in modify step (possible, but requires extra work). Adding a role for a user with that role already does not fail
  • Improved the confirm step to shown reason why updating the user role fails

richard-cox and others added 15 commits February 25, 2020 18:06
@richard-cox
WIP
559d697
@richard-cox
Part 1) Fix Org Service Entity Relations & Pagination Monitor Cacheing
d0ae727 
- Org relations were not correctly passed to action builder
- Pagination Monitor Helper used cache with stail obs
  - Create space. Refresh on stepper, create space, return to stepper and new space was ignored when validating space name
  - Obs containing list of spaces came from pag mon helper cache
  - cache did not contain latest list as cached obs had no subs when new space added
  - more details in code
@richard-cox
Ensure PaginationMonitorFactory passes in isLocal to PaginationMonitor
850625d 
- Ensures the correct obs is returned (first page vs all pages)

Also, in AddEditSpaceStepBase..
- ensure we look for org spaces in the correct place
- unsub from fetch org spaces obs once we have a response
@richard-cox
WIP
8b011c2
@richard-cox
WIP
efe91d3
@richard-cox
WIP
850d853
@richard-cox
Fix create-many script
5c78664
@richard-cox
Merge remote-tracking branch 'origin/master' into add-role-by-username
d0cd637
@richard-cox
Merge remote-tracking branch 'origin/fix-org-relations' into add-role…
4740cb4 
…-by-username
@richard-cox
Fix for org manage, space manager + refresh on space users page
c0a296e
@richard-cox
WIP
628050c
@richard-cox
WIP
dd4c8cf
@richard-cox
Merge remote-tracking branch 'origin/master' into add-role-by-username
5a18798
@richard-cox
Small Tidy Ups
a484978
@richard-cox
Merge remote-tracking branch 'origin/add-role-by-username' into remov…
7e91e40 
…e-role-by-username
@richard-cox richard-cox self-assigned this Mar 17, 2020
richard-cox
richard-cox commented Mar 20, 2020
View reviewed changes
@richard-cox richard-cox added the needs attention This PR needs attention label Mar 23, 2020
@richard-cox richard-cox mentioned this pull request Mar 24, 2020
Closed
@richard-cox richard-cox added comments-addressed and removed needs attention This PR needs attention labels Mar 25, 2020
@richard-cox richard-cox merged commit b6b6a3d into master Mar 30, 2020
@richard-cox richard-cox deleted the remove-role-by-username branch March 30, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@richard-cox richard-cox

Labels

comments-addressed ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow org managers to add users outside of org

1 participant

@richard-cox