Add Cf Role by Username #4171
Closed
Add Cf Role by Username #4171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Mar 17, 2020
richard-cox
commented
- Fixes Allow org managers to add users outside of org #4103
- Added new stepper that adds roles by username
- Stepper can handle multiple users
- New stepper reachable via the org or space users list
- Stepper modify and confirm steps are same as usual manage user roles stepper
- Only difference is existing roles are not shown in modify step (possible, but requires extra work). Adding a role for a user with that role already does not fail
- Improved the confirm step to shown reason why updating the user role fails
- Org relations were not correctly passed to action builder - Pagination Monitor Helper used cache with stail obs - Create space. Refresh on stepper, create space, return to stepper and new space was ignored when validating space name - Obs containing list of spaces came from pag mon helper cache - cache did not contain latest list as cached obs had no subs when new space added - more details in code
- Ensures the correct obs is returned (first page vs all pages) Also, in AddEditSpaceStepBase.. - ensure we look for org spaces in the correct place - unsub from fetch org spaces obs once we have a response
|
Superseded by #4172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.