Keep Logs Enabled when Disabling Envelope Metrics #514
Merged
plowin merged 1 commit intocloudfoundry:developfrom Sep 29, 2025
Merged
Keep Logs Enabled when Disabling Envelope Metrics #514plowin merged 1 commit intocloudfoundry:developfrom
plowin merged 1 commit intocloudfoundry:developfrom
Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
plowin
reviewed
Sep 24, 2025
plowin
previously approved these changes
Sep 24, 2025
Contributor
plowin
left a comment
plowin
left a comment
There was a problem hiding this comment.
LGTM, agree to the breaking change assessment
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
Dariquest
approved these changes
Sep 24, 2025
hoffmaen
force-pushed
the
disable-v1-metrics
branch
3 times, most recently
from
bc2985c to
1a2332c
Compare
hoffmaen
force-pushed
the
disable-v1-metrics
branch
from
1a2332c to
3b98f37
Compare
Contributor
|
LGTM |
plowin
approved these changes
Sep 24, 2025
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
hoffmaen
added a commit
to sap-contributions/cf-community
that referenced
this pull request
Feb 26, 2026
Hello, I am requesting approver status for the Networking group. My contributions so far: Pull-Requests: cloudfoundry/gorouter#442 cloudfoundry/gorouter#435 cloudfoundry/routing-release#519 cloudfoundry/routing-release#514 cloudfoundry/routing-release#504 cloudfoundry/routing-release#453 cloudfoundry/routing-release#434 cloudfoundry/cli#3378 cloudfoundry/cloud_controller_ng#4080 cloudfoundry/cloud_controller_ng#4199 Co-Authorship: cloudfoundry/routing-release#478 Pull-Request Reviews: cloudfoundry/gorouter#443 cloudfoundry/routing-release#452 cloudfoundry/cli#3372 GitHub Issues: cloudfoundry/routing-release#529 cloudfoundry/routing-release#468 cloudfoundry/routing-release#445 cloudfoundry/routing-release#429 cloudfoundry/cloud_controller_ng#4198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With the implementation of Prometheus metrics and the switches to enable/disable Prometheus and Envelope metrics (
enable_envelope_v1_metrics,prometheus.enabled), we are able to replace the Envelope metrics with Prometheus metrics. With the current implementation, the switch to disable Envelope metrics also disables access logs. With this change, access logs are kept even if the Envelope metrics switch is disabled.Backward Compatibility
Breaking Change? No
Setting
enable_envelope_v1_metrics: Falsewill enable access logs with this change. As the switch has been implemented recently, defaults toTrueand doesn't indicate log control, I consider this change as a fix, rather than a breaking change.