Route registry enhancements#478
Merged
maxmoehl merged 8 commits intocloudfoundry:developfrom May 19, 2025
Merged
Conversation
maxmoehl
changed the title
cf-foundation-community-automation
bot
moved this to Inbox
in Application Runtime Platform Working Group
maxmoehl
force-pushed
the
maxmoehl/route-registry-enhancements
branch
from
f58bd8f to
09dd5ac
Compare
Member
Author
|
We've validated this in one of our environments and the metrics now show up with the "refreshed" tag. As expected, the number of route messages labeled as "updated" went down a lot as those are now "refreshed". The logs also behave as expected with the refresh logs (which have a high volume) being not emitted if you set the log level to info. We also ran the routing-release test suite for gorouter and it passes. |
hoffmaen
reviewed
May 7, 2025
hoffmaen
reviewed
May 7, 2025
hoffmaen
reviewed
May 7, 2025
Contributor
|
One more thing: We log the registration of new routes very deep in the code (in |
maxmoehl
force-pushed
the
maxmoehl/route-registry-enhancements
branch
from
dc96907 to
b49cabf
Compare
b1tamara
reviewed
May 8, 2025
hoffmaen
approved these changes
May 9, 2025
Resolves: cloudfoundry#468 Co-Authored-By: Clemens Hoffmann <clemens.hoffmann@sap.com>
maxmoehl
force-pushed
the
maxmoehl/route-registry-enhancements
branch
from
b98740e to
1fea46d
Compare
b1tamara
reviewed
May 12, 2025
src/code.cloudfoundry.org/gorouter/metrics/metricsreporter_test.go
Outdated
Show resolved
Hide resolved
b1tamara
reviewed
May 12, 2025
src/code.cloudfoundry.org/gorouter/metrics/metricsreporter_test.go
Outdated
Show resolved
Hide resolved
b1tamara
reviewed
May 12, 2025
b1tamara
reviewed
May 12, 2025
b1tamara
reviewed
May 12, 2025
b1tamara
reviewed
May 12, 2025
Resolves: cloudfoundry#468 Co-Authored-By: Clemens Hoffmann <clemens.hoffmann@sap.com>
Co-Authored-By: Clemens Hoffmann <clemens.hoffmann@sap.com> Co-Authored-By: Soha Alboghdady <soha.alboghdady@sap.com>
Co-Authored-By: Clemens Hoffmann <clemens.hoffmann@sap.com> Co-Authored-By: Soha Alboghdady <soha.alboghdady@sap.com>
maxmoehl
force-pushed
the
maxmoehl/route-registry-enhancements
branch
from
1fea46d to
0eb9044
Compare
maxmoehl
force-pushed
the
maxmoehl/route-registry-enhancements
branch
from
e1bf949 to
e648904
Compare
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Application Runtime Platform Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Application Runtime Platform Working Group
hoffmaen
added a commit
to sap-contributions/cf-community
that referenced
this pull request
Feb 26, 2026
Hello, I am requesting approver status for the Networking group. My contributions so far: Pull-Requests: cloudfoundry/gorouter#442 cloudfoundry/gorouter#435 cloudfoundry/routing-release#519 cloudfoundry/routing-release#514 cloudfoundry/routing-release#504 cloudfoundry/routing-release#453 cloudfoundry/routing-release#434 cloudfoundry/cli#3378 cloudfoundry/cloud_controller_ng#4080 cloudfoundry/cloud_controller_ng#4199 Co-Authorship: cloudfoundry/routing-release#478 Pull-Request Reviews: cloudfoundry/gorouter#443 cloudfoundry/routing-release#452 cloudfoundry/cli#3372 GitHub Issues: cloudfoundry/routing-release#529 cloudfoundry/routing-release#468 cloudfoundry/routing-release#445 cloudfoundry/routing-release#429 cloudfoundry/cloud_controller_ng#4198
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rework some of the route registry logic to reduce nested ifs and align some of the logic.
Backward Compatibility
Breaking Change? No