Skip to content

Allow setting of DynaTrace agent name via environment variable #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tom-collings wants to merge 3 commits into from
Closed

Allow setting of DynaTrace agent name via environment variable #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
314a7ad
adding spec for env variable setting agent name
Sep 30, 2015
ff8772b
Added support to allow for the setting of the DynaTrace agent name vi…
Sep 30, 2015
74ba1dc
Add Support for Environment-Driven DynaTrace agent names
Sep 30, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/java_buildpack/framework/dyna_trace_agent.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def agent_path
end

def agent_name
"#{@application.details['application_name']}_#{profile_name}"
ENV['JBP_CONFIG_DYNATRACE_AGENT_NAME'] || "#{@application.details['application_name']}_#{profile_name}"
end

def architecture
Expand Down
19 changes: 19 additions & 0 deletions spec/java_buildpack/framework/dyna_trace_agent_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,23 @@
end

end

context do

let(:environment) { { 'JBP_CONFIG_DYNATRACE_AGENT_NAME' => 'environment-set-application-name' } }

before do
allow(services).to receive(:one_service?).with(/dynatrace/, 'server').and_return(true)
allow(services).to receive(:find_service).and_return('credentials' => { 'server' => 'test-host-name' })
end

it 'updates JAVA_OPTS with custom environment variable' do
component.release
expect(java_opts).to include(
'-agentpath:$PWD/.java-buildpack/dyna_trace_agent/agent/lib64/'\
'libdtagent.so=name=environment-set-application-name,server=test-host-name')
end

end

end