Allow setting of DynaTrace agent name via environment variable#235
Closed
tom-collings wants to merge 3 commits intocloudfoundry:masterfrom
tom-collings:master
Closed
Allow setting of DynaTrace agent name via environment variable#235tom-collings wants to merge 3 commits intocloudfoundry:masterfrom tom-collings:master
tom-collings wants to merge 3 commits intocloudfoundry:masterfrom
tom-collings:master
Conversation
…a the environment variable JBP_CONFIG_DYNATRACE_AGENT_NAME. If this environment variable exists, the value wull be used for the agent name. If the value does not exist, then the default value (application name) will be used.
Allow the configuration of a DynaTrace agent name by setting the JBP_CONFIG_DYNATRACE_AGENT_NAME environment variable. If the environment variable exists, use that value. If it does not, use the default behaviour, which is the application name. Issue #234
|
Hey tom-collings! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. |
Contributor
|
Completed in 6e53039 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer has asked for a non-default (that is, something different than the application name) to be used for the DynaTrace agent name. By setting an environment variable, we can allow end users to set the agent name.
The environment variable is JBP_CONFIG_DYNATRACE_AGENT_NAME. If it exists, the value of this environment variable will be used for the DynaTrace agent name in the JVM Options. If it does not exist, the default behaviour (using the application name) will be used.
This is my first foray into ruby. I used other ruby files in the buildpack as a general style guide, any feedback will be greatly appreciated.
Also, its unclear how to sign the CLA. Should I be receiving some notification with instructions?