Skip to content

[quick-edit] Add C++20 compatibility fix for Node.js 24 #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
petebacondarwin wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[quick-edit] Add C++20 compatibility fix for Node.js 24 #12287

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
710856f
[quick-edit] Add C++20 compatibility fix for Node.js 24
petebacondarwin Jan 29, 2026
b14989e
[quick-edit] Use Node 22 for quick-edit deployment
petebacondarwin Jan 29, 2026
f33812f
[quick-edit] Use nvm to switch to Node 22 for native module compilation
petebacondarwin Jan 29, 2026
5abb09c
[quick-edit] Use setup-node action to switch to Node 22 for preview
petebacondarwin Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/deploy-pages-previews.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ jobs:

- name: Install Dependencies
uses: ./.github/actions/install-dependencies
with:
# Use Node 24 to test nvm fallback to Node 22 for quick-edit native module compilation
node-version: 24

- name: Build tools and libraries
run: pnpm run build
Expand All @@ -61,6 +64,14 @@ jobs:
env:
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}

# Quick Edit requires Node 22 because it builds native modules (tree-sitter)
# that are not compatible with Node 24's C++20 requirement for V8 headers
- name: Switch to Node 22 for Quick Edit
if: contains(github.event.*.labels.*.name, 'preview:quick-edit')
uses: actions/setup-node@v4
with:
node-version: 22

- name: Build and Deploy Quick Edit preview
if: contains(github.event.*.labels.*.name, 'preview:quick-edit')
run: pnpm --filter quick-edit run preview
Expand Down
Loading