[quick-edit] Add C++20 compatibility fix for Node.js 24 #12287
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the quick-edit deployment failure on Node.js 24 caused by native module compilation errors.
Problem
Node.js 24 requires C++20 for V8 headers. When building quick-edit, the
tree-sitternative module in VSCode'svendor/vscode/build/directory fails to compile with errors like:Solution
This change adds a workflow step using
actions/setup-node@v4to switch to Node 22 before running the quick-edit preview/deploy. This approach:Changes
.github/workflows/deploy-pages-previews.yml:Testing
To test this fix:
preview:quick-editlabel to this PRpreview:quick-editlabel is added