[vite-plugin] add a check for installed wrangler version #11265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 780fac8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
2 times, most recently
from
ee49ae0 to
a646a29
Compare
petebacondarwin
changed the title
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
from
4f528ce to
2a83e23
Compare
ascorbic
approved these changes
Dec 12, 2025
This change delays confusing "missing export" failures to allow us to run a more user friendly version skew check, for when the user installs a version of Wrangler that breaks the plugin
…being used internally is correct This is necessary because some package managers will incorrectly merge peer dependencies with actual dependencies (often ignoring peer dependency constraints).
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>
petebacondarwin
force-pushed
the
pbd/vite-plugin/check-wrangler-version
branch
from
2a83e23 to
780fac8
Compare
Merged
vicb
added a commit
that referenced
this pull request
Dec 12, 2025
vicb
added a commit
that referenced
this pull request
Dec 15, 2025
vicb
added a commit
that referenced
this pull request
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just #11176 but on the cloudflare org for easier testing.
Fixes [DEVX-2229]
Adds a check to ensure that the locally-installed version of wrangler meets the peer dependency requirements of the Vite plugin. This is required because of package managers with lax enforcement of peerdep ranges, which isn't acceptable for us as it can cause breakages.