[vite-plugin] add a check for installed wrangler version #11176

ascorbic · 2025-11-05T11:13:09Z

Fixes [DEVX-2229]

This PR is mostly based on and supersedes #10848, but I've not stacked them because it includes updates from main to resolve conflicts. My changes are all in 8641dc6 so you may want to review that specifically.

Adds a check to ensure that the locally-installed version of wrangler meets the peer dependency requirements of the Vite plugin. This is required because of package managers with lax enforcement of peerdep ranges, which isn't acceptable for us as it can cause breakages.

Tests
- Tests included
- Tests not necessary because:
Public documentation
- Cloudflare docs PR(s):
- Documentation not necessary because: internal fix
Wrangler V3 Backport
- Wrangler PR:
- Not necessary because: not Wrangler

changeset-bot · 2025-11-05T11:13:13Z

🦋 Changeset detected

Latest commit: c890500

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-11-05T11:27:53Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11176

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11176

miniflare

npm i https://pkg.pr.new/miniflare@11176

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11176

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11176

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11176

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11176

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11176

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11176

wrangler

npm i https://pkg.pr.new/wrangler@11176

commit: 00ec8c7

packages/vite-plugin-cloudflare/src/assert-wrangler-version.ts

packages/vite-plugin-cloudflare/src/deploy-config.ts

packages/vite-plugin-cloudflare/src/miniflare-options.ts

packages/vite-plugin-cloudflare/package.json

ascorbic · 2025-11-05T11:43:46Z

Looks like Windows needs it to fail earlier, so I've moved it back up to the module level so it fails as soon as the config loads. The error isn't as nice (which is why I moved it into the config hook before), but it seems that's too late for Windows.

IgorMinar · 2025-11-05T14:58:13Z

omg thank you @petebacondarwin and @ascorbic !!! I was bitten by this one before and it's painful to know what's going on without an explicit check.

This change delays confusing "missing export" failures to allow us to run a more user friendly version skew check, for when the user installs a version of Wrangler that breaks the plugin

…being used internally is correct This is necessary because some package managers will incorrectly merge peer dependencies with actual dependencies (often ignoring peer dependency constraints).

…angler being used internally is correct

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

ascorbic · 2025-11-13T12:39:21Z

Might be worth re-opening your PR and pushing my commits to it, so that CI works better

petebacondarwin · 2025-11-13T13:29:50Z

Yeah. I'll try that in parallel to this...

petebacondarwin · 2025-11-13T13:38:35Z

Opened #11265

* Avoid using object lookup for OAuth Error classes * fixup! Avoid using object lookup for OAuth Error classes

…0703) * feat: add streaming tail consumer configuration support Implement [[streaming_tail_consumer]] configuration similar to tail_consumer, sending to streamingTails instead of tails. Includes: - Configuration schema and validation for streaming_tail_consumers - Miniflare integration with streamingTails support - Development and deployment workflow updates - Print bindings integration for CLI output - Comprehensive test coverage 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fixups * Create clever-eggs-sit.md * fix types * Work in Vite + Vitest * fix tests * Add E2E test * Address comments --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Samuel Macleod <smacleod@cloudflare.com> Co-authored-by: Somhairle MacLeòid <samuel@macleod.space>

* Support the WRANGLER_HIDE_BANNER environment variable across Wrangler & C3 * Reduce C3 framework test timeout. Previously it was 25 mins, now it should be 3 mins * Remove dev server from C3 command. To make this consistent across frameworks we were injecting extra dev commands into package.json files, which meant that generated C3 projects often had both a `start` and a `develop` script. * Reduce logging in package-manager detection * Expand autoconfig & use it in C3 for gatsby * Expand framework configuration and support dry-running * Address comments * Address comments * longer timeout 😢

…rameworks (cloudflare#11013) * [C3] Bump sv in /packages/create-cloudflare/src/frameworks Bumps [sv](https://github.com/sveltejs/cli/tree/HEAD/packages/cli) from 0.9.8 to 0.9.9. - [Release notes](https://github.com/sveltejs/cli/releases) - [Changelog](https://github.com/sveltejs/cli/blob/main/packages/cli/CHANGELOG.md) - [Commits](https://github.com/sveltejs/cli/commits/sv@0.9.9/packages/cli) --- updated-dependencies: - dependency-name: sv dependency-version: 0.9.9 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: update dependencies of "create-cloudflare" package The following dependency versions have been updated: | Dependency | From | To | | ---------- | ----- | ----- | | sv | 0.9.8 | 0.9.9 | --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>

…loudflare/src/frameworks (cloudflare#11015) * [C3] Bump create-docusaurus Bumps [create-docusaurus](https://github.com/facebook/docusaurus/tree/HEAD/packages/create-docusaurus) from 3.9.1 to 3.9.2. - [Release notes](https://github.com/facebook/docusaurus/releases) - [Changelog](https://github.com/facebook/docusaurus/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/docusaurus/commits/v3.9.2/packages/create-docusaurus) --- updated-dependencies: - dependency-name: create-docusaurus dependency-version: 3.9.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: update dependencies of "create-cloudflare" package The following dependency versions have been updated: | Dependency | From | To | | ----------------- | ----- | ----- | | create-docusaurus | 3.9.1 | 3.9.2 | --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>

) * Ensure process.on(exit) listeners are only added once * Add changeset

…rc/frameworks (cloudflare#11222) * [C3] Bump nuxi in /packages/create-cloudflare/src/frameworks Bumps [nuxi](https://github.com/nuxt/cli/tree/HEAD/packages/nuxi) from 3.29.3 to 3.30.0. - [Release notes](https://github.com/nuxt/cli/releases) - [Commits](https://github.com/nuxt/cli/commits/v3.30.0/packages/nuxi) --- updated-dependencies: - dependency-name: nuxi dependency-version: 3.30.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: update dependencies of "create-cloudflare" package The following dependency versions have been updated: | Dependency | From | To | | ---------- | ------ | ------ | | nuxi | 3.29.3 | 3.30.0 | --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>

…1235) * Bump the workerd-and-workers-types group with 2 updates Bumps the workerd-and-workers-types group with 2 updates: [workerd](https://github.com/cloudflare/workerd) and [@cloudflare/workers-types](https://github.com/cloudflare/workerd). Updates `workerd` from 1.20251109.0 to 1.20251111.0 - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/Dockerfile.release) - [Commits](cloudflare/workerd@v1.20251109.0...v1.20251111.0) Updates `@cloudflare/workers-types` from 4.20251109.0 to 4.20251111.0 - [Release notes](https://github.com/cloudflare/workerd/releases) - [Changelog](https://github.com/cloudflare/workerd/blob/main/Dockerfile.release) - [Commits](https://github.com/cloudflare/workerd/commits) --- updated-dependencies: - dependency-name: workerd dependency-version: 1.20251111.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: workerd-and-workers-types - dependency-name: "@cloudflare/workers-types" dependency-version: 4.20251111.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: workerd-and-workers-types ... Signed-off-by: dependabot[bot] <support@github.com> * chore: update dependencies of "miniflare" package The following dependency versions have been updated: | Dependency | From | To | | ---------- | ------------ | ------------ | | workerd | 1.20251109.0 | 1.20251111.0 | --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wrangler automated PR updater <wrangler@cloudflare.com>

* Fix typo that meant static routing exclude rules were being evaluated in both Vite and the Router Worker * Add changeset * Update changeset * Update changeset

* fix: use .dev.vars when envFiles is empty array * Add tests

…angler being used internally is correct

petebacondarwin · 2025-12-11T14:06:31Z

I've fixed this PR up on the internal branch one (#11265). So I think we can close this and finish the review there.

ascorbic requested a review from a team as a code owner November 5, 2025 11:13

ascorbic requested a review from a team November 5, 2025 11:13

ascorbic changed the title ~~Pbd/vite plugin/check wrangler version~~ [vite-plugin] add a check for installed wrangler version Nov 5, 2025

workers-devprod added this to workers-sdk Nov 5, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Nov 5, 2025

penalosa reviewed Nov 5, 2025

View reviewed changes

ascorbic requested a review from penalosa November 5, 2025 11:46

penalosa approved these changes Nov 5, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 5, 2025

ascorbic requested a review from penalosa November 5, 2025 13:01

petebacondarwin mentioned this pull request Nov 7, 2025

Add a check to vite-plugin that ensures that the version of Wrangler being used internally is correct #10848

Closed

6 tasks

petebacondarwin self-assigned this Nov 11, 2025

petebacondarwin force-pushed the pbd/vite-plugin/check-wrangler-version branch 2 times, most recently from 856bc1c to 056b217 Compare November 11, 2025 17:40

petebacondarwin and others added 12 commits November 13, 2025 11:46

Allow vite-plugin e2e test to turn off strict-peers installation

7f4bf03

refactor: vite-plugin to use wrangler default export

d058925

This change delays confusing "missing export" failures to allow us to run a more user friendly version skew check, for when the user installs a version of Wrangler that breaks the plugin

Add a check to vite-plugin that ensures that the version of Wrangler …

786e5b3

…being used internally is correct This is necessary because some package managers will incorrectly merge peer dependencies with actual dependencies (often ignoring peer dependency constraints).

fixup! Add a check to vite-plugin that ensures that the version of Wr…

1df80cc

…angler being used internally is correct

fixup! Add a check to vite-plugin that ensures that the version of Wr…

b95f3a6

…angler being used internally is correct

fixup! Add a check to vite-plugin that ensures that the version of Wr…

b5f28bb

…angler being used internally is correct

Apply suggestion from @jamesopstad

e03eb46

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

Apply suggestion from @jamesopstad

ff931ef

Co-authored-by: James Opstad <13586373+jamesopstad@users.noreply.github.com>

Simplify wrangler version check logic

a3aa65e

Move assertion up to module level

fdecca1

Remove package.json export

8c2cc40

Await assertion

958ce08

petebacondarwin force-pushed the pbd/vite-plugin/check-wrangler-version branch from 056b217 to 958ce08 Compare November 13, 2025 11:48

petebacondarwin mentioned this pull request Nov 13, 2025

[vite-plugin] add a check for installed wrangler version #11265

Merged

6 tasks

ascorbic and others added 18 commits November 13, 2025 15:57

Fix test

00ec8c7

refactor: simply R2 code (cloudflare#11260)

da719bc

Avoid using object lookup for OAuth Error classes (cloudflare#11261)

7aad9d5

* Avoid using object lookup for OAuth Error classes * fixup! Avoid using object lookup for OAuth Error classes

chore: ignore generated folder (cloudflare#11263)

911707f

Fixes hello-world-with-assets Python template (cloudflare#11170)

ad12f77

Ensure process.on("exit") handlers are only added once (cloudflare#11274

e31d473

) * Ensure process.on(exit) listeners are only added once * Add changeset

refactor: share config for related KV commands (cloudflare#11271)

af438c8

Bump to toucan v4 (cloudflare#11217)

ee73cac

refactor: export property validators (cloudflare#11269)

2338996

Fix typo (cloudflare#11273)

4114f80

* Fix typo that meant static routing exclude rules were being evaluated in both Vite and the Router Worker * Add changeset * Update changeset * Update changeset

fix: use .dev.vars when envFiles is empty array (cloudflare#11278)

da528ab

* fix: use .dev.vars when envFiles is empty array * Add tests

fixup! Add a check to vite-plugin that ensures that the version of Wr…

c890500

…angler being used internally is correct

petebacondarwin requested a review from a team as a code owner November 14, 2025 11:39

petebacondarwin closed this Dec 11, 2025

github-project-automation bot moved this from Approved to Done in workers-sdk Dec 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[vite-plugin] add a check for installed wrangler version #11176

[vite-plugin] add a check for installed wrangler version #11176

Uh oh!

ascorbic commented Nov 5, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ascorbic commented Nov 5, 2025

Uh oh!

IgorMinar commented Nov 5, 2025

Uh oh!

ascorbic commented Nov 13, 2025

Uh oh!

petebacondarwin commented Nov 13, 2025

Uh oh!

petebacondarwin commented Nov 13, 2025

Uh oh!

petebacondarwin commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

[vite-plugin] add a check for installed wrangler version #11176

[vite-plugin] add a check for installed wrangler version #11176

Uh oh!

Conversation

ascorbic commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ascorbic commented Nov 5, 2025

Uh oh!

IgorMinar commented Nov 5, 2025

Uh oh!

ascorbic commented Nov 13, 2025

Uh oh!

petebacondarwin commented Nov 13, 2025

Uh oh!

petebacondarwin commented Nov 13, 2025

Uh oh!

petebacondarwin commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ascorbic commented Nov 5, 2025 •

edited

Loading

changeset-bot bot commented Nov 5, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 5, 2025 •

edited

Loading