-
Notifications
You must be signed in to change notification settings - Fork 1k
use the Cloudflare maintained Next.js template #11132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
petebacondarwin
wants to merge
2
commits into
main
Choose a base branch
from
pbd/c3/lockdown-next-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−30
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "create-cloudflare": patch | ||
| --- | ||
|
|
||
| use the Cloudflare maintained Next.js template |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about moving the template to the OpenNext repo instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely an option. The question is who will maintain it?
If we put it in OpenNext will it be kept up to date (at least more than than the Cloudflare templates repo)?
If there is no capacity to maintain it in Open Next then at least there is a team that is supposed to be on the hook to maintain the templates repo. I am told that this is a template they do intend to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are 2 things to take into consideration here:
About the maintenance:
I have never been in contact with that team which is not a positive signal ("not positive" != negative). I just opened the template and see that for ex it doesn't configure binding access in the next config (i.e. calling
initOpenNextCloudflareForDev).Second question is what would framework support be split across different teams?
Last question is how to test changes in the template. It's pretty easy to do that today with a local build of c3. What about moving the template to another repo (either the templates or the open next repo).
Impact on users:
With the current template, users can create a Next app at any Next version as long as it is supported by the adapter (latest 14 minor and any 15 as of today).
The proposed template used a fixed version of Next.
Probably not a huge deal to instantiate 14 or 15 but I can foresee that it becomes a problem when 16 is supported. Implementing the Adapters API will probably imply a different template.