- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1k
 
use the Cloudflare maintained Next.js template #11132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
          🦋 Changeset detectedLatest commit: 659cd66 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
          create-cloudflare
 @cloudflare/kv-asset-handler
 miniflare
 @cloudflare/pages-shared
 @cloudflare/unenv-preset
 @cloudflare/vite-plugin
 @cloudflare/vitest-pool-workers
 @cloudflare/workers-editor-shared
 @cloudflare/workers-utils
 wrangler
 commit:   | 
    
9e28ccd    to
    a382216      
    Compare
  
    21d4581    to
    4000f41      
    Compare
  
    | // This is a template maintained by Cloudflare that is based on a standard Next.js starter project, | ||
| // and has already been configured to work with Cloudflare Workers | ||
| "--example", | ||
| "https://github.com/cloudflare/templates/tree/main/next-starter-template", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about moving the template to the OpenNext repo instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's definitely an option. The question is who will maintain it?
If we put it in OpenNext will it be kept up to date (at least more than than the Cloudflare templates repo)?
If there is no capacity to maintain it in Open Next then at least there is a team that is supposed to be on the hook to maintain the templates repo. I am told that this is a template they do intend to maintain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are 2 things to take into consideration here:
- impact on maintenance
 - impact on the users
 
About the maintenance:
I have never been in contact with that team which is not a positive signal ("not positive" != negative). I just opened the template and see that for ex it doesn't configure binding access in the next config (i.e. calling initOpenNextCloudflareForDev).
Second question is what would framework support be split across different teams?
Last question is how to test changes in the template. It's pretty easy to do that today with a local build of c3. What about moving the template to another repo (either the templates or the open next repo).
Impact on users:
With the current template, users can create a Next app at any Next version as long as it is supported by the adapter (latest 14 minor and any 15 as of today).
The proposed template used a fixed version of Next.
Probably not a huge deal to instantiate 14 or 15 but I can foresee that it becomes a problem when 16 is supported. Implementing the Adapters API will probably imply a different template.
4000f41    to
    659cd66      
    Compare
  
    
Uh oh!
There was an error while loading. Please reload this page.