Skip to content

Conversation

@petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Oct 30, 2025


  • Tests
    • Tests included
    • Tests not necessary because: already tested in C3
  • Public documentation
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: C3 is not backported

@petebacondarwin petebacondarwin added the skip-v3-pr Skip validation of presence of a v3 backport PR label Oct 30, 2025
@petebacondarwin petebacondarwin requested a review from a team as a code owner October 30, 2025 11:12
@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2025

🦋 Changeset detected

Latest commit: 659cd66

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11132

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11132

miniflare

npm i https://pkg.pr.new/miniflare@11132

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11132

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11132

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11132

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11132

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11132

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11132

wrangler

npm i https://pkg.pr.new/wrangler@11132

commit: 4000f41

@petebacondarwin petebacondarwin force-pushed the pbd/c3/lockdown-next-template branch from 9e28ccd to a382216 Compare October 30, 2025 11:15
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Oct 31, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/c3/lockdown-next-template branch from 21d4581 to 4000f41 Compare October 31, 2025 12:41
// This is a template maintained by Cloudflare that is based on a standard Next.js starter project,
// and has already been configured to work with Cloudflare Workers
"--example",
"https://github.com/cloudflare/templates/tree/main/next-starter-template",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about moving the template to the OpenNext repo instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely an option. The question is who will maintain it?
If we put it in OpenNext will it be kept up to date (at least more than than the Cloudflare templates repo)?
If there is no capacity to maintain it in Open Next then at least there is a team that is supposed to be on the hook to maintain the templates repo. I am told that this is a template they do intend to maintain.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are 2 things to take into consideration here:

  1. impact on maintenance
  2. impact on the users

About the maintenance:

I have never been in contact with that team which is not a positive signal ("not positive" != negative). I just opened the template and see that for ex it doesn't configure binding access in the next config (i.e. calling initOpenNextCloudflareForDev).

Second question is what would framework support be split across different teams?

Last question is how to test changes in the template. It's pretty easy to do that today with a local build of c3. What about moving the template to another repo (either the templates or the open next repo).

Impact on users:

With the current template, users can create a Next app at any Next version as long as it is supported by the adapter (latest 14 minor and any 15 as of today).

The proposed template used a fixed version of Next.

Probably not a huge deal to instantiate 14 or 15 but I can foresee that it becomes a problem when 16 is supported. Implementing the Adapters API will probably imply a different template.

@petebacondarwin petebacondarwin force-pushed the pbd/c3/lockdown-next-template branch from 4000f41 to 659cd66 Compare November 3, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-v3-pr Skip validation of presence of a v3 backport PR

Projects

Status: Approved

Development

Successfully merging this pull request may close these issues.

3 participants