Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miniflare 3 fails to install against NodeJS 18/19 #518

Closed
vlovich opened this issue Feb 22, 2023 · 1 comment · Fixed by #521
Closed

Miniflare 3 fails to install against NodeJS 18/19 #518

vlovich opened this issue Feb 22, 2023 · 1 comment · Fixed by #521

Comments

@vlovich
Copy link
Contributor

vlovich commented Feb 22, 2023

Build fails with ./src/util/macros.lzz:157:21: error: ‘v8::AccessorSignature’ has not been declared.

WiseLibs/better-sqlite3#891

Downgrading to nodejs 16 before installing miniflare 3 is a workaround.
mrbbot added a commit that referenced this issue Feb 23, 2023
@mrbbot
Bump to better-sqlite3@8.1.0, closes #518
0be4c0b 
Fixes installation on Node 19

Closes cloudflare/workers-sdk#2318
@mrbbot mrbbot linked a pull request Feb 23, 2023 that will close this issue
[Miniflare 3] Bump to better-sqlite3@8.1.0, closes #518 #521
Merged
mrbbot added a commit that referenced this issue Feb 27, 2023
@mrbbot
Bump to better-sqlite3@8.1.0, closes #518
4839d65 
Fixes installation on Node 19

Closes cloudflare/workers-sdk#2318
@vlovich
Copy link
Contributor Author

vlovich commented Mar 2, 2023

Confirmed fixed.

@vlovich vlovich closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Miniflare 3] Bump to better-sqlite3@8.1.0, closes #518 cloudflare/miniflare
1 participant
@vlovich