Binaries for nodejs 19 #891

zdm · 2022-10-18T17:10:22Z

Unable to compile for nodejs 19:

prebuild info begin Prebuild version 11.0.4
prebuild info build Preparing to prebuild better-sqlite3@7.6.2 for node 19.0.0 on linux-x64 using node-gyp
gyp info find Python using Python version 3.8.10 found at "/usr/bin/python3"
gyp http GET https://nodejs.org/download/release/v19.0.0/node-v19.0.0-headers.tar.gz
gyp http 200 https://nodejs.org/download/release/v19.0.0/node-v19.0.0-headers.tar.gz
gyp http GET https://nodejs.org/download/release/v19.0.0/SHASUMS2[56](https://github.com/softvisio/sqlite/actions/runs/3275382262/jobs/5390155918#step:4:57).txt
gyp http 200 https://nodejs.org/download/release/v19.0.0/SHASUMS256.txt
gyp info spawn /usr/bin/python3
gyp info spawn args [
gyp info spawn args   '/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/node_modules/prebuild/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/node_modules/prebuild/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/tmp/prebuild/node/19.0.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/tmp/prebuild/node/19.0.0',
gyp info spawn args   '-Dnode_gyp_dir=/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/node_modules/prebuild/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/tmp/prebuild/node/19.0.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/build'
  TOUCH ba23eeee118cd63e16015df367567cb043fed872.intermediate
  ACTION deps_sqlite3_gyp_locate_sqlite3_target_copy_builtin_sqlite3 ba23eeee118cd63e16015df367567cb043fed872.intermediate
  TOUCH Release/obj.target/deps/locate_sqlite3.stamp
  CC(target) Release/obj.target/sqlite3/gen/sqlite3/sqlite3.o
rm -f Release/obj.target/deps/sqlite3.a Release/obj.target/deps/sqlite3.a.ar-file-list; mkdir -p `dirname Release/obj.target/deps/sqlite3.a`
ar crs Release/obj.target/deps/sqlite3.a @Release/obj.target/deps/sqlite3.a.ar-file-list
  COPY Release/sqlite3.a
  CXX(target) Release/obj.target/better_sqlite3/src/better_sqlite3.o
In file included from ./src/better_sqlite3.lzz:11,
                 from ../src/better_sqlite3.cpp:4:
/tmp/prebuild/node/19.0.0/include/node/node.h:996:51: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>)’ to ‘node::addon_context_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)’} [-Wcast-function-type]
  996 |       (node::addon_context_register_func) (regfunc),                  \
      |                                                   ^
/tmp/prebuild/node/19.0.0/include/node/node.h:1014:3: note: in expansion of macro ‘NODE_MODULE_CONTEXT_AWARE_X’
 1014 |   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/tmp/prebuild/node/19.0.0/include/node/node.h:1045:3: note: in expansion of macro ‘NODE_MODULE_CONTEXT_AWARE’
 1045 |   NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME,                     \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~
./src/better_sqlite3.lzz:67:1: note: in expansion of macro ‘NODE_MODULE_INIT’
./src/util/macros.lzz: In function ‘void SetPrototypeGetter(v8::Isolate*, v8::Local<v8::External>, v8::Local<v8::FunctionTemplate>, const char*, v8::AccessorGetterCallback)’:
./src/util/macros.lzz:1[57](https://github.com/softvisio/sqlite/actions/runs/3275382262/jobs/5390155918#step:4:58):21: error: ‘v8::AccessorSignature’ has not been declared
./src/util/binder.lzz: In static member function ‘static bool Binder::IsPlainObject(v8::Isolate*, v8::Local<v8::Object>)’:
./src/util/binder.lzz:37:51: error: ‘class v8::Object’ has no member named ‘CreationContext’; did you mean ‘GetCreationContext’?
./src/util/data.lzz: In function ‘v8::Local<v8::Value> Data::GetValueJS(v8::Isolate*, sqlite3_stmt*, int, bool)’:
./src/util/data.lzz:73:92: warning: this statement may fall through [-Wimplicit-fallthrough=]
./src/util/data.lzz:73:197: note: here
./src/util/data.lzz: In function ‘v8::Local<v8::Value> Data::GetValueJS(v8::Isolate*, sqlite3_value*, bool)’:
./src/util/data.lzz:77:81: warning: this statement may fall through [-Wimplicit-fallthrough=]
./src/util/data.lzz:77:175: note: here
make: *** [better_sqlite3.target.mk:125: Release/obj.target/better_sqlite3/src/better_sqlite3.o] Error 1
rm ba23eeee118cd63e1[60](https://github.com/softvisio/sqlite/actions/runs/3275382262/jobs/5390155918#step:4:61)15df3[67](https://github.com/softvisio/sqlite/actions/runs/3275382262/jobs/5390155918#step:4:68)567cb043fed8[72](https://github.com/softvisio/sqlite/actions/runs/3275382262/jobs/5390155918#step:4:73).intermediate
make: Leaving directory '/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/build'
prebuild ERR! build error 
prebuild ERR! stack Error: `make` failed with exit code: 2
prebuild ERR! stack     at ChildProcess.onExit (/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/node_modules/prebuild/node_modules/node-gyp/lib/build.js:203:23)
prebuild ERR! stack     at ChildProcess.emit (node:events:513:28)
prebuild ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:2[93](https://github.com/softvisio/sqlite/actions/runs/3275382262/jobs/5390155918#step:4:94):12)
prebuild ERR! not ok 
prebuild ERR! build Error: `make` failed with exit code: 2
prebuild ERR! build     at ChildProcess.onExit (/home/runner/work/sqlite/sqlite/build/node_modules/better-sqlite3/node_modules/prebuild/node_modules/node-gyp/lib/build.js:203:23)
prebuild ERR! build     at ChildProcess.emit (node:events:513:28)
prebuild ERR! build     at ChildProcess._handle.onexit (node:internal/child_process:293:12)
Error: Process completed with exit cod

The text was updated successfully, but these errors were encountered:

CharlesEkkel · 2022-10-23T05:28:27Z

I can confirm this issue is replicable, I've been having it all afternoon. Below is the result of trying to add better-sqlite3 to an empty project generated using yarn init, with directory names redacted for privacy.

Edit: this issue can be circumvented by using an older version of node, as mentioned by @leafac in the linked issue above. But that's just circumventing the issue by using a pre-built binary.

>>> yarn add better-sqlite3
yarn add v1.22.19
info No lockfile found.
[1/4] Resolving packages...
[2/4] Fetching packages...
[3/4] Linking dependencies...
[4/4] Building fresh packages...
error [PROJECT DIR]/node_modules/better-sqlite3: Command failed.
Exit code: 1
Command: prebuild-install || npm run build-release
Arguments: 
Directory: [PROJECT DIR]/node_modules/better-sqlite3
Output:
prebuild-install warn install No prebuilt binaries found (target=19.0.0 runtime=node arch=x64 libc= platform=linux)

> better-sqlite3@7.6.2 build-release
> node-gyp rebuild --release

gyp info it worked if it ends with ok
gyp info using node-gyp@9.3.0
gyp info using node@19.0.0 | linux | x64
gyp info find Python using Python version 3.10.8 found at "/sbin/python3"
gyp info spawn /sbin/python3
gyp info spawn args [
gyp info spawn args   '/usr/lib/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '[PROJECT DIR]/node_modules/better-sqlite3/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/usr/lib/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '[$HOME]/.cache/node-gyp/19.0.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=[$HOME]/.cache/node-gyp/19.0.0',
gyp info spawn args   '-Dnode_gyp_dir=/usr/lib/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=[$HOME]/.cache/node-gyp/19.0.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=[PROJECT DIR]/node_modules/better-sqlite3',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.'
gyp info spawn args ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '[PROJECT DIR]/node_modules/better-sqlite3/build'
  TOUCH ba23eeee118cd63e16015df367567cb043fed872.intermediate
  ACTION deps_sqlite3_gyp_locate_sqlite3_target_copy_builtin_sqlite3 ba23eeee118cd63e16015df367567cb043fed872.intermediate
  TOUCH Release/obj.target/deps/locate_sqlite3.stamp
  CC(target) Release/obj.target/sqlite3/gen/sqlite3/sqlite3.o
rm -f Release/obj.target/deps/sqlite3.a Release/obj.target/deps/sqlite3.a.ar-file-list; mkdir -p `dirname Release/obj.target/deps/sqlite3.a`
ar crs Release/obj.target/deps/sqlite3.a @Release/obj.target/deps/sqlite3.a.ar-file-list
  COPY Release/sqlite3.a
  CXX(target) Release/obj.target/better_sqlite3/src/better_sqlite3.o
In file included from ./src/better_sqlite3.lzz:11,
                 from ../src/better_sqlite3.cpp:4:
[$HOME]/.cache/node-gyp/19.0.0/include/node/node.h:996:7: warning: cast between incompatible function types from ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>)’ to ‘node::addon_context_register_func’ {aka ‘void (*)(v8::Local<v8::Object>, v8::Local<v8::Value>, v8::Local<v8::Context>, void*)’} [-Wcast-function-type]
  996 |       (node::addon_context_register_func) (regfunc),                  \
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[$HOME]/.cache/node-gyp/19.0.0/include/node/node.h:1014:3: note: in expansion of macro ‘NODE_MODULE_CONTEXT_AWARE_X’
 1014 |   NODE_MODULE_CONTEXT_AWARE_X(modname, regfunc, NULL, 0)
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[$HOME]/.cache/node-gyp/19.0.0/include/node/node.h:1045:3: note: in expansion of macro ‘NODE_MODULE_CONTEXT_AWARE’
 1045 |   NODE_MODULE_CONTEXT_AWARE(NODE_GYP_MODULE_NAME,                     \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~
./src/better_sqlite3.lzz:67:1: note: in expansion of macro ‘NODE_MODULE_INIT’
./src/util/macros.lzz: In function ‘void SetPrototypeGetter(v8::Isolate*, v8::Local<v8::External>, v8::Local<v8::FunctionTemplate>, const char*, v8::AccessorGetterCallback)’:
./src/util/macros.lzz:157:21: error: ‘v8::AccessorSignature’ has not been declared
./src/util/binder.lzz: In static member function ‘static bool Binder::IsPlainObject(v8::Isolate*, v8::Local<v8::Object>)’:
./src/util/binder.lzz:37:51: error: ‘class v8::Object’ has no member named ‘CreationContext’; did you mean ‘GetCreationContext’?
./src/util/data.lzz: In function ‘v8::Local<v8::Value> Data::GetValueJS(v8::Isolate*, sqlite3_stmt*, int, bool)’:
./src/util/data.lzz:73:92: warning: this statement may fall through [-Wimplicit-fallthrough=]
./src/util/data.lzz:73:197: note: here
./src/util/data.lzz: In function ‘v8::Local<v8::Value> Data::GetValueJS(v8::Isolate*, sqlite3_value*, bool)’:
./src/util/data.lzz:77:81: warning: this statement may fall through [-Wimplicit-fallthrough=]
./src/util/data.lzz:77:175: note: here
make: *** [better_sqlite3.target.mk:123: Release/obj.target/better_sqlite3/src/better_sqlite3.o] Error 1
rm ba23eeee118cd63e16015df367567cb043fed872.intermediate
make: Leaving directory '[PROJECT DIR]/node_modules/better-sqlite3/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/lib/node_modules/node-gyp/lib/build.js:203:23)
gyp ERR! stack     at ChildProcess.emit (node:events:513:28)
gyp ERR! stack     at ChildProcess._handle.onexit (node:internal/child_process:293:12)
gyp ERR! System Linux 5.19.13-arch1-1
gyp ERR! command "/usr/bin/node" "/usr/lib/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--release"
gyp ERR! cwd [PROJECT DIR]/node_modules/better-sqlite3
gyp ERR! node -v v19.0.0
gyp ERR! node-gyp -v v9.3.0
gyp ERR! not ok

zdm · 2022-10-23T05:47:47Z

Anybody can confirm it because nodejs api was changed and better-sqlite sources requires update.
We are waiting for @JoshuaWise .

ceticamarco · 2022-10-27T09:43:56Z

Same issue here. Works fine with latest LTS though.

realamirhe · 2022-11-02T13:16:35Z

I faced the same issue with nodes 16.18and18.12`, but non of them worked.
It is not about the incompatibility with the node version I guess it might be related to the platform (system)

In my case, it is solved by following the actions

Set the path of the python into my .zshrc file
Update xcode-select (xcode-select --install) with the latest version (link)

zdm · 2022-11-04T04:40:20Z

@JoshuaWise Joshua, could you, please, take a look, if you are currently not busy? Something was changed in nodejs 19
and currently it is not compiling.

irgaly · 2022-11-07T17:24:04Z

It seems #870 will fix this issue.

#870 fixes error: ‘v8::AccessorSignature’ has not been declared and error: ‘class v8::Object’ has no member named ‘CreationContext’ errors.

zdm · 2022-11-10T08:35:42Z

Yes, PR #870 works for windows. linux and mac.

JoshuaWise · 2022-11-22T00:25:46Z

I'm releasing a major version with this fix tonight.

zdm mentioned this issue Oct 22, 2022

Failed to install better-sqlite3 with Node.js 19.0.0 in macOS #892

Closed

fzn0x mentioned this issue Oct 23, 2022

Use better-sqlite3 sequelize/sequelize#11400

Open

CountMurphy mentioned this issue Oct 27, 2022

Incompatable with nodejs 19 bonukai/MediaTracker#439

Closed

jNullj mentioned this issue Oct 28, 2022

Cant build container jNullj/Pikabot#44

Closed

This was referenced Nov 13, 2022

Error when installing on linux #899

Closed

Unable to install #900

Closed

JoshuaWise closed this as completed Nov 22, 2022

bttger mentioned this issue Nov 29, 2022

Error when building v7.6.2 on Node 19 #913

Closed

sbstratos79 mentioned this issue Dec 6, 2022

npm install fails after better-sqlite3 funmaker/Hybooru#19

Closed

ThisIsTheOnlyUsernameAvailable mentioned this issue Dec 9, 2022

Change better-sqlite3 dependency cross-seed/cross-seed#336

Closed

jakubgs mentioned this issue Jan 16, 2023

Yarn add is not working status-im/status-mobile#14651

Closed

vlovich mentioned this issue Feb 22, 2023

Miniflare 3 fails to install against NodeJS 18/19 cloudflare/miniflare#518

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Binaries for nodejs 19 #891

Binaries for nodejs 19 #891

zdm commented Oct 18, 2022

CharlesEkkel commented Oct 23, 2022 •

edited

Loading

zdm commented Oct 23, 2022

ceticamarco commented Oct 27, 2022

realamirhe commented Nov 2, 2022 •

edited

Loading

zdm commented Nov 4, 2022

irgaly commented Nov 7, 2022

zdm commented Nov 10, 2022

JoshuaWise commented Nov 22, 2022

Binaries for nodejs 19 #891

Binaries for nodejs 19 #891

Comments

zdm commented Oct 18, 2022

CharlesEkkel commented Oct 23, 2022 • edited Loading

zdm commented Oct 23, 2022

ceticamarco commented Oct 27, 2022

realamirhe commented Nov 2, 2022 • edited Loading

zdm commented Nov 4, 2022

irgaly commented Nov 7, 2022

zdm commented Nov 10, 2022

JoshuaWise commented Nov 22, 2022

CharlesEkkel commented Oct 23, 2022 •

edited

Loading

realamirhe commented Nov 2, 2022 •

edited

Loading