Jwineman/react155 #125
Merged
Jwineman/react155 #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2017 21:32
Contributor
|
This is relevant formatjs/formatjs#918 |
Contributor
Author
|
Ah I'd forgotten about that, I'm watching that issue as well. I'd like to merge now if thats okay. The warnings don't show up in production bundles and there is no break in functionality. |
Contributor
|
We can merge once we finish the task completely. There's no urgency
…On Mon, May 1, 2017, 16:26 John Wineman ***@***.***> wrote:
Ah I'd forgotten about that, I'm watching that issue as well. I'd like to
merge now if thats okay. The warnings don't show up in production bundles
and there is no break in functionality.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#125 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGYVlHwFuut7A0ENEp0vBSh2yqrnSGUSks5r1fmXgaJpZM4NM1hx>
.
|
Contributor
Author
|
I want to avoid a rebase and since we're blocked by timelines we can't control from our dependencies I'd rather do this in pieces rather than one large change. |
Contributor
Author
|
Merging per our conversation |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are warnings from
react-selectwhichcf-component-selectdepends on. Being tracked here:JedWatson/react-select#1658
I'll PR again when they patch.