Migrate to prop-types and create-react-class packages #1658

agirton · 2017-04-10T17:59:08Z

In React 15.5 they are starting the process to migrate away from having PropTypes and createClass under the main React object. This PR updates all of the related files needed to use the new packages.

I ran all of the unit tests and also tested the examples app after the changes. Both had no errors/issues.

merlinstardust · 2017-04-13T17:51:07Z

package.json

+    "create-react-class": "15.5.1",
    "classnames": "^2.2.4",
-    "react-input-autosize": "^1.1.0"
+    "react-input-autosize": "^1.1.0",


This dependency will need to be updated as well. I've created a PR here to do so

The lib has been updated, fixed version is 1.1.1

react-autosize-input still needs to publish version 1.1.1 to npm

react-autosize-input has released v1.1.3 :-)

DimaRGB · 2017-04-27T13:45:36Z

Have some problems in CI for node[v4], Error: Cannot find module 'object-assign'

malimccalla · 2017-04-30T09:02:25Z

When can we expect this fix? It's my only package still throwing the warnings

coveralls · 2017-05-01T03:45:04Z

Coverage increased (+0.2%) to 92.883% when pulling 03b3da2 on agirton:migrate-to-external-pkgs into a0e5855 on JedWatson:master.

agirton · 2017-05-01T03:46:49Z

@JedWatson this should be good to go.

tomasztomys · 2017-05-02T09:55:06Z

When can we expect release new version with this PR?

ddrozdov · 2017-05-02T17:54:50Z

@JedWatson would you merge this please?

marcellodesales · 2017-05-03T06:02:10Z

Just got this error :( Can't load my component... :( Any workaround?

bmv437 · 2017-05-03T12:57:42Z

@marcellodesales technically in react 15.5 this is just a warning and shouldn't prevent the component from loading. When react 16 is released, it will be a breaking change.

laalex · 2017-05-06T12:14:50Z

👍

erictaylor · 2017-05-08T02:50:04Z

Merge @JedWatson?

bertho-zero · 2017-05-10T08:18:13Z

You can use npm i JedWatson/react-select#pull/1658/head waiting merge...

Edit: @agirton You forgot to run gulp build, no ?

ijxsid · 2017-05-10T12:25:28Z

I am still getting the folllowing warning when running the package from npm. Do I need to install the package from git?

warning.js:36 Warning: AsyncCreatableSelect: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

DimaRGB · 2017-05-10T13:46:07Z

@FalloutX, needs to merge this pr.

JedWatson · 2017-05-14T13:25:44Z

Looks great @agirton, thanks and sorry for the delay merging (I've been away for personal reasons)

Will get this published asap so everyone stops getting annoyed by those warnings!

@JedWatson

commit 07dc061 Author: cbergmiller <christian@bergmiller.de> Date: Tue Jun 6 07:04:20 2017 +0200 [ADD] Clarified the onInputChange prop signature in the docs (JedWatson#1773) * [ADD] Clarified the onInputChange prop signature in the docs * [ADD] requested changes commit 40db517 Author: cbergmiller <christian@bergmiller.de> Date: Sat Jun 3 15:53:45 2017 +0200 [FIX] JedWatson#1651 moved option prop sync to componentWillReceiveProps (JedWatson#1765) * [FIX] JedWatson#1651 moved option prop sync to componentWillReceiveProps * [ADD] test for option prop sync by componentWillReceiveProps commit 1d15068 Author: Jed Watson <jed.watson@me.com> Date: Thu May 25 00:25:19 2017 +1000 v1.0.0-rc.5 commit e06ea57 Author: Jed Watson <jed.watson@me.com> Date: Thu May 25 00:25:09 2017 +1000 Updating build commit 7013005 Merge: 9943711 8239201 Author: Jed Watson <jed.watson@me.com> Date: Thu May 25 00:19:49 2017 +1000 Merge pull request JedWatson#1738 from agirton/chore/HISTORY-update Update change log for rc5 release. commit 8239201 Author: Adam Girton <adam.girton@me.com> Date: Sat May 20 10:37:18 2017 -0700 Update changelog commit 9943711 Author: Benjamin Piouffle <Betree@users.noreply.github.com> Date: Fri May 19 07:21:40 2017 +1100 Fix selected option focus when valueKey is not "value" (JedWatson#1733) * Fix selected option focus when valueKey is not "value" * Revert "Fix selected option focus when valueKey is not "value"" This reverts commit 45f5665. * Fix on src/ instead of lib/ commit 196c7bb Author: Max Hubenthal <Max_Hubenthal@carmax.com> Date: Wed May 17 12:47:29 2017 -0400 Fix aria owns value (JedWatson#1556) commit fd19b91 Author: Simon Gaestel <simon.gaestel+git@gmail.com> Date: Wed May 17 18:22:34 2017 +0200 Fix JedWatson#1394 (JedWatson#1395) * Fix JedWatson#1394 * Updates following review * Updates following review by @JedWatson commit 549d20a Author: Jed Watson <jed.watson@me.com> Date: Mon May 15 00:00:05 2017 +1000 v1.0.0-rc.4 commit 5269a85 Merge: af8f58d 75d6372 Author: Jed Watson <jed.watson@me.com> Date: Sun May 14 23:31:30 2017 +1000 Merge pull request JedWatson#1652 from dan-diaz/isClearable Include a className of 'is-clearable' if clearable is true commit af8f58d Merge: 8ff4596 9150107 Author: Jed Watson <jed.watson@me.com> Date: Sun May 14 23:27:19 2017 +1000 Merge pull request JedWatson#1659 from lagun4ik/master Added variables for shadow styles commit 8ff4596 Merge: a0e5855 03b3da2 Author: Jed Watson <jed.watson@me.com> Date: Sun May 14 23:25:48 2017 +1000 Merge pull request JedWatson#1658 from agirton/migrate-to-external-pkgs Migrate to prop-types and create-react-class packages commit 03b3da2 Author: Adam Girton <adam.girton@me.com> Date: Sun Apr 30 20:41:54 2017 -0700 Bumping create-react-class and prop-types commit 387f241 Author: Adam Girton <adam.girton@me.com> Date: Sun Apr 30 20:35:55 2017 -0700 Update react-input-autosize dep commit 9150107 Author: lagun4ik <ivan@lagunovsky.com> Date: Mon Apr 10 21:55:48 2017 +0300 added variables for shadow styles commit d7d2a79 Author: Adam Girton <adam.girton@me.com> Date: Mon Apr 10 09:55:46 2017 -0700 Move over examples to use new pkgs commit feabc4d Author: Adam Girton <adam.girton@me.com> Date: Mon Apr 10 09:55:17 2017 -0700 Migrate rest of src overto createClass pkg commit ace3e08 Author: Adam Girton <adam.girton@me.com> Date: Mon Apr 10 09:44:54 2017 -0700 Migrate src over to creatClass package commit 16ff8e9 Author: Adam Girton <adam.girton@me.com> Date: Mon Apr 10 09:38:37 2017 -0700 Use new prop-types package commit 75d6372 Author: DDiaz <daniel.diaz@isobar.com> Date: Thu Apr 6 10:39:10 2017 -0400 spaces to tabs commit c81b9c9 Author: DDiaz <daniel.diaz@isobar.com> Date: Thu Apr 6 10:37:15 2017 -0400 Include a className of 'is-clearable' if clearable is true

agirton added 4 commits April 10, 2017 10:53

Use new prop-types package

16ff8e9

Migrate src over to creatClass package

ace3e08

Migrate rest of src overto createClass pkg

feabc4d

Move over examples to use new pkgs

d7d2a79

delveintechnolabs mentioned this pull request Apr 11, 2017

Deprecation warnings with React 15.5.3 #1661

Closed

merlinstardust reviewed Apr 13, 2017

View reviewed changes

agirton added 2 commits April 30, 2017 20:35

Update react-input-autosize dep

387f241

Bumping create-react-class and prop-types

03b3da2

jwineman mentioned this pull request May 1, 2017

Jwineman/react155 cloudflare/cloudflare-plugin-frontend#125

Merged

tomasztomys approved these changes May 2, 2017

View reviewed changes

agirton mentioned this pull request May 2, 2017

Fix "Module create-react-class not found" (fix #1697) #1698

Closed

JasonKleban approved these changes May 2, 2017

View reviewed changes

laytong mentioned this pull request May 4, 2017

Refactor: migrate React components to ES6 classes. #1702

Closed

cheeaun mentioned this pull request May 8, 2017

⬆️ fix proptypes / react version #1703

Closed

kvnxush approved these changes May 9, 2017

View reviewed changes

seb-bizeul mentioned this pull request May 12, 2017

React v15.5.4 gives PropTypes and React.createClass depreciated warning #1717

Closed

JedWatson merged commit 8ff4596 into JedWatson:master May 14, 2017

agirton deleted the migrate-to-external-pkgs branch May 16, 2017 04:19

jochenberger mentioned this pull request May 18, 2017

remove create-react-class dependency from main sources #1734

Closed

jwineman mentioned this pull request May 22, 2017

Update react-select to 1.0.0-rc.4 for react 15.5 support for cf-component-select cloudflare/cf-ui#200

Merged

Migrate to prop-types and create-react-class packages #1658

Migrate to prop-types and create-react-class packages #1658

Uh oh!

Conversation

agirton commented Apr 10, 2017

Uh oh!

merlinstardust Apr 13, 2017

Choose a reason for hiding this comment

Uh oh!

Betree Apr 18, 2017

Choose a reason for hiding this comment

Uh oh!

bmv437 Apr 28, 2017

Choose a reason for hiding this comment

Uh oh!

MichaelDeBoey Apr 29, 2017

Choose a reason for hiding this comment

Uh oh!

DimaRGB commented Apr 27, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

malimccalla commented Apr 30, 2017

Uh oh!

coveralls commented May 1, 2017

Uh oh!

agirton commented May 1, 2017

Uh oh!

tomasztomys commented May 2, 2017

Uh oh!

ddrozdov commented May 2, 2017

Uh oh!

marcellodesales commented May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bmv437 commented May 3, 2017

Uh oh!

laalex commented May 6, 2017

Uh oh!

erictaylor commented May 8, 2017

Uh oh!

bertho-zero commented May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ijxsid commented May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DimaRGB commented May 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JedWatson commented May 14, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

DimaRGB commented Apr 27, 2017 •

edited

Loading

marcellodesales commented May 3, 2017 •

edited

Loading

bertho-zero commented May 10, 2017 •

edited

Loading

ijxsid commented May 10, 2017 •

edited

Loading

DimaRGB commented May 10, 2017 •

edited

Loading