[Workers] Update "Custom Ports" known issue to reflect dev-time only behaviour #9324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change made in PR cloudflare#7514 assumes that custom ports work with HTTP requests, however, this is not true. PR cloudflare#5255 did correctly mention the dev-time discrepancy but it was not merged.
deadlypants1973
changed the title
irvinebroque
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
Thanks for flagging this. Small copy edits but 🚀
@mrbbot @admah @lrapoport-cf for visibility — wonder if we should update local dev / Quick Editor to more closely mirror production behavior.
|
@irvinebroque tempted to leave it as-is in local dev. We log a warning when you try to |
irvinebroque
requested review from
a team,
GregBrimble and
WalshyDev
as code owners
|
+1 to the comment from @mrbbot. As long as it's documented here, I'm good with leaving the local dev experience as-is. |
yusukebe
pushed a commit
that referenced
this pull request
Aug 29, 2023
…behaviour (#9324) * Update "Custom Ports" known issue to reflect dev-time only behaviour The change made in PR #7514 assumes that custom ports work with HTTP requests, however, this is not true. PR #5255 did correctly mention the dev-time discrepancy but it was not merged. * Apply suggestions from code review --------- Co-authored-by: Brendan Irvine-Broque <brendanib@gmail.com> Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change made in PR #7514 assumes that custom ports work with HTTP requests, however, this is not true.
PR #5255 did correctly mention the dev-time discrepancy but it was not merged.
Weirdly, it is possible to open up a TCP socket to the HTTP server on the custom port using the recent TCP sockets runtime API, and craft a HTTP request + parse the HTTP response by hand.
Because of this, the decision to restrict custom ports when using
fetchmay be now be defeated by this new TCP socket API?