[Workers] Custom ports known issue #7514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
angelampcosta,
dcpena,
haleycode,
kodster28,
marciocloudflare,
patriciasantaana,
pedrosousa and
ranbel
GregBrimble
reviewed
Feb 1, 2023
GregBrimble
approved these changes
Feb 1, 2023
Deploying with
|
| Latest commit: |
fae0af2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://351f23ae.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://kate-fixes-ports.cloudflare-docs-7ou.pages.dev |
greg suggestion Co-authored-by: Greg Brimble <gbrimble@cloudflare.com>
kodster28
approved these changes
Feb 1, 2023
xdjoshuaaz
added a commit
to xdjoshuaaz/cloudflare-docs
that referenced
this pull request
Jun 11, 2023
The change made in PR cloudflare#7514 assumes that custom ports work with HTTP requests, however, this is not true. PR cloudflare#5255 did correctly mention the dev-time discrepancy but it was not merged.
irvinebroque
added a commit
that referenced
this pull request
Jul 26, 2023
…behaviour (#9324) * Update "Custom Ports" known issue to reflect dev-time only behaviour The change made in PR #7514 assumes that custom ports work with HTTP requests, however, this is not true. PR #5255 did correctly mention the dev-time discrepancy but it was not merged. * Apply suggestions from code review --------- Co-authored-by: Brendan Irvine-Broque <brendanib@gmail.com> Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
yusukebe
pushed a commit
that referenced
this pull request
Aug 29, 2023
…behaviour (#9324) * Update "Custom Ports" known issue to reflect dev-time only behaviour The change made in PR #7514 assumes that custom ports work with HTTP requests, however, this is not true. PR #5255 did correctly mention the dev-time discrepancy but it was not merged. * Apply suggestions from code review --------- Co-authored-by: Brendan Irvine-Broque <brendanib@gmail.com> Co-authored-by: Brendan Irvine-Broque <birvine-broque@cloudflare.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5998