Remove UnknownEncodingMessageReader and replace with exceptions #262 #277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Javadoc'ed more and more the api module Cleanup the CloudEventRWException More tests on the API module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Use parseTime Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Better docs on the Extensions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Signed-off-by: Sreenath Madasu <MADASUSX@legal.regn.net>
Member
|
Can you fix the dco? If you look in the details, it shows you how |
slinkydeveloper
requested changes
Nov 16, 2020
Member
slinkydeveloper
left a comment
slinkydeveloper
left a comment
There was a problem hiding this comment.
Can you add a test for parseStructuredOrBinaryMessage that tests all three cases (encoding binary, encoding structured and exception thrown for unknown encoding)?
core/src/main/java/io/cloudevents/core/message/impl/MessageUtils.java
Outdated
Show resolved
Hide resolved
…events#262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com>
smadasu
force-pushed
the
Unknown_Encoding_Cleanup
branch
from
7e6b2b9 to
e3fbbf6
Compare
…ded Unit tests cloudevents#262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com>
smadasu
force-pushed
the
Unknown_Encoding_Cleanup
branch
from
e31ab8e to
c8682e8
Compare
…xed compile error cloudevents#262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com>
slinkydeveloper
requested changes
Nov 21, 2020
…anged exception name and details cloudevents#262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com> Signed-off-by: Sreenath Madasu <MADASUSX@legal.regn.net>
smadasu
force-pushed
the
Unknown_Encoding_Cleanup
branch
from
27ad380 to
fa3b286
Compare
Member
|
SGTM, can you fix the broken tests? |
Member
|
Maybe you need a rebase on latest upstream/master |
Member
|
Thanks for the contribution, I solved the broken test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed UNKNOWN encoding and replaced class with Exception. Please approve.