Javadoc'ed + Cleanup of the api module #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
changed the title
matejvasek
approved these changes
Nov 13, 2020
Cleanup the CloudEventRWException More tests on the API module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
invalid_data_type
branch
from
b68f585 to
e386ecd
Compare
Member
Author
|
@matejvasek can you review this again? I rebased |
matejvasek
reviewed
Nov 13, 2020
matejvasek
approved these changes
Nov 13, 2020
smadasu
pushed a commit
to smadasu/sdk-java
that referenced
this pull request
Nov 15, 2020
* Javadoc'ed more and more the api module Cleanup the CloudEventRWException More tests on the API module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Use parseTime Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Better docs on the Extensions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Signed-off-by: Sreenath Madasu <MADASUSX@legal.regn.net>
slinkydeveloper
added a commit
that referenced
this pull request
Nov 26, 2020
…277) * Javadoc'ed + Cleanup of the api module (#267) * Javadoc'ed more and more the api module Cleanup the CloudEventRWException More tests on the API module Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Use parseTime Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> * Better docs on the Extensions Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Signed-off-by: Sreenath Madasu <MADASUSX@legal.regn.net> * Remove UnknownEncodingMessageReader and replace with exceptions #262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com> * Remove UnknownEncodingMessageReader and replace with exceptions -- Added Unit tests #262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com> * Remove UnknownEncodingMessageReader and replace with exceptions -- Fixed compile error #262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com> * Remove UnknownEncodingMessageReader and replace with exceptions -- changed exception name and details #262 Signed-off-by: Sreenath Madasu <Sreenath.Madasu@gmail.com> Signed-off-by: Sreenath Madasu <MADASUSX@legal.regn.net> * Fixed Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Francesco Guardiani <francescoguard@gmail.com> Co-authored-by: Sreenath Madasu <MADASUSX@legal.regn.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
CloudEventRWExceptionTimeoverrides ofparseTimeandwriteTimeto generate the properCloudEventRWException. Also using this methods when appropriateSigned-off-by: Francesco Guardiani francescoguard@gmail.com