Glue core & api #157
Glue core & api #157
Conversation
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
glue_core_api
branch
from
5d654a0 to
a07ebb0
Compare
core/src/main/java/io/cloudevents/builder/CloudEventBuilder.java
Outdated
Show resolved
Hide resolved
|
@slinkydeveloper nice! Happy to see the |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
| case V03: | ||
| return CloudEventBuilder.v03(); | ||
| } | ||
| return null; |
There was a problem hiding this comment.
But that's a condition that can never happen, SpecVersion or is V1 or is V03. SpecVersion version on the other hand should be non null
There was a problem hiding this comment.
After this pr, we should review all these annotation usages in all modules, I'm quite sure there are some places where we miss these
There was a problem hiding this comment.
Maybe throw IllegallStateException then
There was a problem hiding this comment.
The only way this could happen is that there is misalignment between core and api versions, let me explicit it
|
|
||
| default CloudEvent toEvent() throws MessageVisitException, IllegalStateException { | ||
| return this.visit(EventFormat::deserialize); | ||
| public static CloudEventVisitable toVisitable(CloudEvent event) { |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
bsideup
left a comment
bsideup
left a comment
There was a problem hiding this comment.
Nice! I did a (very) quick review of core and did not find anything that would not make me approve it, especially given that the api module was not touched 👍
The package change is also nice 💯
From the PoV of api module consumer, this change looks good, thanks! 🎉
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
@bsideup thanks for the quick review! |
|
I'll second Sergei. The |
|
great to see this, thanks @slinkydeveloper! |
5 participants
Fix #156
Each commit represent one of the steps explained in #156.
Deprecates #147 and #150