Reimplemented Spec version conversion #147
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
changed the title
This was referenced May 15, 2020
Merged
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Proposed set of apis for CloudEvent Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Changes Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Javadocs Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Removed CloudEventBuilder.java Signed-off-by: Francesco Guardiani <francescoguard@gmail.com> Nits Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
spec_version_conversion
branch
from
d4f24c9 to
caa145f
Compare
Member
Author
|
Rebased on top of #150 and ready to be merged. Please let me know any concerns |
This was referenced May 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #150
Removed spec version conversion inside
CloudEventinterface andAttributesinterface. Now to convert an event from one spec version to another, user should go through builders:Signed-off-by: Francesco Guardiani francescoguard@gmail.com