GCP: Add support for specifying the backups storage bucket. #134
Conversation
Signed-off-by: Jesus Perez Rey <jprey@bluemetrix.com>
There was a problem hiding this comment.
Hi @chusopr,
Apologies for the delay in getting to this PR. All looks good apart from one change to the backup_location parameter in cloudera.cloud.env.
Once that's in place we will aim to get the update into the next release.
| public_ip: "{{ plat__use_public_ip }}" | ||
| log_location: "gs://{{ plat__gcp_storage_location_logs }}" | ||
| log_identity: "{{ plat__gcp_log_identity_name }}@{{ plat__gcp_project }}.iam.gserviceaccount.com" | ||
| backups_location: "gs://{{ plat__gcp_storage_location_backups }}" |
There was a problem hiding this comment.
This cloudera.cloud.env parameter is called backup_location.
I think it's because we used the change from cloudera-labs/cloudera.cloud#95 instead of cloudera-labs/cloudera.cloud#80.
There was a problem hiding this comment.
I guess it would make sense changing the rest of the variable names (infra.gcp.storage.path.backups, env.gcp.storage.path.backups, common__backups_path, etc) also to singular for consistency?
There was a problem hiding this comment.
Yes that would be good. Although I see that log(s) has the same inconsistencies!
|
Closing as changes have been added in #172. |
3 participants
When the backups storage path is not set, it defaults to the logs bucket as that's the current behaviour:
cloudera.exe/roles/common/defaults/main.yml
Line 106 in ab0ce02
Tested by deploying an environment where the backup storage bucket was explicitly set to be different than the logs one and another one where it was not set.