Skip to content

Commit ab0ce02

Browse files
committed
GCP: Add support for specifying the backups storage bucket.
Signed-off-by: Jesus Perez Rey <jprey@bluemetrix.com>
1 parent d8895b6 commit ab0ce02

File tree

6 files changed

+14
-5
lines changed

6 files changed

+14
-5
lines changed

roles/common/defaults/main.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ common__ml_path: "{{ infra.storage.path.ml | default('d
103103
common__de_path: "{{ infra.storage.path.de | default('dataeng') }}"
104104
common__logs_path: "{{ infra.storage.path.logs | default(common__logs_suffix) }}"
105105
common__data_path: "{{ infra.storage.path.data | default(common__data_suffix) }}"
106+
common__backups_path: "{{ infra.storage.path.backups | default(common__logs_path) }}"
106107
common__ranger_audit_path: "{{ infra.storage.path.ranger_audit | default('ranger/audit') }}"
107108

108109
# AWS Infra

roles/infrastructure/defaults/main.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,7 @@ infra__storage_name: "{{ common__storage_name }}"
6868

6969
infra__logs_path: "{{ common__logs_path }}"
7070
infra__data_path: "{{ common__data_path }}"
71+
infra__backups_path: "{{ common__backups_path }}"
7172
infra__ranger_audit_path: "{{ common__ranger_audit_path }}"
7273

7374
infra__public_key_path: "{{ globals.ssh.key_path | default('~/.ssh') }}"
@@ -131,8 +132,9 @@ infra__aws_private_endpoints: "{{ infra.aws.vpc.private_endpoints | defaul
131132
# GCP
132133
infra__gcp_project: "{{ common__gcp_project }}"
133134

134-
infra__gcp_storage_location_data: "{{ infra.gcp.storage.path.data | default([infra__storage_name, infra__data_path] | join('-')) }}"
135-
infra__gcp_storage_location_logs: "{{ infra.gcp.storage.path.logs | default([infra__storage_name, infra__logs_path] | join('-')) }}"
135+
infra__gcp_storage_location_data: "{{ infra.gcp.storage.path.data | default([infra__storage_name, infra__data_path] | join('-')) }}"
136+
infra__gcp_storage_location_logs: "{{ infra.gcp.storage.path.logs | default([infra__storage_name, infra__logs_path] | join('-')) }}"
137+
infra__gcp_storage_location_backups: "{{ infra.gcp.storage.path.backups | default(infra__gcp_storage_location_logs) }}"
136138

137139
infra__gcp_cloud_router_name_suffix: "{{ infra.gcp.network.router.name_suffix | default('router') }}"
138140
infra__gcp_cloud_router_name: "{{ infra.gcp.network.router.name | default([infra__namespace, infra__gcp_cloud_router_name_suffix] | join('-')) }}"
@@ -170,4 +172,4 @@ infra__utlity_bucket_name: "{{ globals.utility_bucket_name | default(''
170172

171173
# Teardown
172174
infra__force_teardown: "{{ common__force_teardown }}"
173-
infra__env_name: "{{ common__env_name }}" # Used for purge lookups
175+
infra__env_name: "{{ common__env_name }}" # Used for purge lookups

roles/infrastructure/tasks/initialize_gcp.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,12 @@
3838
fail_msg: "Gcloud Collection failed to retrieve resources, you may need to run 'gcloud auth login' or 'gcloud init': {{ __gcp_vpc_info }}"
3939
quiet: yes
4040

41-
- name: Set fact for Log and Data locations
41+
- name: Set fact for Log, Backups and Data locations
4242
ansible.builtin.set_fact:
4343
infra__gcp_storage_locations: "{{ infra__gcp_storage_locations | default([]) | union([__gcp_storage_location_item]) }}"
4444
loop_control:
4545
loop_var: __gcp_storage_location_item
4646
loop:
4747
- "{{ infra__gcp_storage_location_data }}"
48-
- "{{ infra__gcp_storage_location_logs }}"
48+
- "{{ infra__gcp_storage_location_logs }}"
49+
- "{{ infra__gcp_storage_location_backups }}"

roles/platform/defaults/main.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ plat__storage_name: "{{ common__storage_name }}"
5252

5353
plat__logs_path: "{{ common__logs_path }}"
5454
plat__data_path: "{{ common__data_path }}"
55+
plat__data_path: "{{ common__backups_path }}"
5556

5657
plat__public_key_id: "{{ common__public_key_id }}"
5758
plat__public_key_text: "{{ common__public_key_text }}"
@@ -165,6 +166,7 @@ plat__gcp_idbroker_identity_name: "{{ env.gcp.role.name.idbroker | d
165166

166167
plat__gcp_storage_location_data: "{{ env.gcp.storage.path.data | default([plat__storage_name, plat__data_path] | join('-')) }}"
167168
plat__gcp_storage_location_logs: "{{ env.gcp.storage.path.logs | default([plat__storage_name, plat__logs_path] | join('-')) }}"
169+
plat__gcp_storage_location_backups: "{{ env.gcp.storage.path.backups | default(plat__gcp_storage_location_logs) }}"
168170

169171
plat__gcp_xaccount_policy_bindings: "{{ env.gcp.bindings.cross_account | default(plat__gcp_xaccount_policy_bindings_default) }}"
170172
plat__gcp_log_role_perms: "{{ env.gcp.bindings.logs | default(plat__gcp_log_policy_bindings_default) }}"

roles/platform/tasks/setup_gcp_authz.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,8 @@
167167
loop:
168168
- account: "serviceAccount:{{ plat__gcp_log_identity_name }}@{{ plat__gcp_project }}.iam.gserviceaccount.com:admin"
169169
bucket: "{{ plat__gcp_storage_location_logs }}"
170+
- account: "serviceAccount:{{ plat__gcp_log_identity_name }}@{{ plat__gcp_project }}.iam.gserviceaccount.com:admin"
171+
bucket: "{{ plat__gcp_storage_location_backups }}"
170172
- account: "serviceAccount:{{ plat__gcp_datalakeadmin_identity_name }}@{{ plat__gcp_project }}.iam.gserviceaccount.com:admin"
171173
bucket: "{{ plat__gcp_storage_location_data }}"
172174
- account: "serviceAccount:{{ plat__gcp_ranger_audit_identity_name }}@{{ plat__gcp_project }}.iam.gserviceaccount.com:admin"

roles/platform/tasks/setup_gcp_env.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
public_ip: "{{ plat__use_public_ip }}"
2626
log_location: "gs://{{ plat__gcp_storage_location_logs }}"
2727
log_identity: "{{ plat__gcp_log_identity_name }}@{{ plat__gcp_project }}.iam.gserviceaccount.com"
28+
backups_location: "gs://{{ plat__gcp_storage_location_backups }}"
2829
vpc_id: "{{ plat__vpc_name }}"
2930
subnet_ids:
3031
- "{{ plat__gcp_subnets_discovered[0].name }}" # TODO - Check in validation_gcp.yml -- CDP on GCP only supports a single subnet deployment

0 commit comments

Comments
 (0)