Skip to content

fix(gitlab): iterate over pagination#1918

Merged
shikanime merged 1 commit intomainfrom
pr1918
Feb 25, 2026
Merged

fix(gitlab): iterate over pagination#1918
shikanime merged 1 commit intomainfrom
pr1918

Conversation

@shikanime
Copy link
Contributor

@shikanime shikanime commented Feb 12, 2026

Current implementation assume that the API return the whole list, which is not truth.

Related: #1916
Co-authored-by: William Phetsinorath william.phetsinorath@shikanime.studio
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr


Stack created with Sapling. Best reviewed with ReviewStack.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

🤖 Hey !

The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

🤖 Hey !

The @cpn-console/sonarqube-plugin (v2.0.5) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

🤖 Hey !

The @cpn-console/argocd-plugin (v2.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

1 similar comment
@github-actions
Copy link
Contributor

🤖 Hey !

The @cpn-console/argocd-plugin (v2.3.0) package already exists on npm but the source code has changed, you should consider updating the package version.

The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc...

@github-actions github-actions bot added the built label Feb 13, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2026

🤖 Hey !

The security scan report for the current pull request is available here.

@shikanime shikanime marked this pull request as draft February 13, 2026 09:27
@shikanime shikanime marked this pull request as ready for review February 13, 2026 09:30
@shikanime shikanime requested review from StephaneTrebel and removed request for StephaneTrebel February 16, 2026 12:57
@shikanime shikanime force-pushed the pr1918 branch 2 times, most recently from ad08dc2 to b248ed7 Compare February 16, 2026 15:04
StephaneTrebel
StephaneTrebel previously approved these changes Feb 18, 2026
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On ajoute beaucoup de code, et pas assez de tests. Faudrait qu'on priorise le sujet... LGTM

@github-actions
Copy link
Contributor

🤖 Hey !

A preview of the application is available at : https://console-pr-1918.dso.cpin-hp.numerique-interieur.fr

Please be patient, deployment may take a few minutes.

StephaneTrebel
StephaneTrebel previously approved these changes Feb 24, 2026
StephaneTrebel
StephaneTrebel previously approved these changes Feb 24, 2026
Copy link
Collaborator

@StephaneTrebel StephaneTrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Current implementation assume that the API return the whole list, which is not truth.

Related: #1916
Co-authored-by: William Phetsinorath <william.phetsinorath@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
@cloud-pi-native-sonarqube
Copy link

@StephaneTrebel StephaneTrebel self-requested a review February 25, 2026 13:13
@shikanime shikanime added this pull request to the merge queue Feb 25, 2026
Merged via the queue into main with commit 9ebce61 Feb 25, 2026
33 checks passed
@shikanime shikanime deleted the pr1918 branch February 25, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working built preview Deploy preview app with Argo-cd tech Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants