Conversation
|
🤖 Hey ! The @cpn-console/hooks (v4.0.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/keycloak-plugin (v2.1.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/sonarqube-plugin (v2.0.5) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/shared (v1.3.0) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The @cpn-console/gitlab-plugin (v3.3.1) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
shikanime
changed the title
|
🤖 Hey ! The security scan report for the current pull request is available here. |
shikanime
force-pushed
the
pr1905
branch
5 times, most recently
from
2f6f9b7 to
a123c81
Compare
shikanime
force-pushed
the
pr1905
branch
6 times, most recently
from
5468a36 to
f12d4db
Compare
shikanime
force-pushed
the
pr1905
branch
6 times, most recently
from
511439f to
8a478df
Compare
shikanime
force-pushed
the
pr1905
branch
2 times, most recently
from
92a8d9d to
84bcb96
Compare
Co-authered-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
shikanime
dismissed
StephaneTrebel’s stale review
The base branch was changed.
|
0 New Issues
2 Fixed Issues
0 Accepted Issues
No data about coverage (71.10% Estimated after merge)
StephaneTrebel
left a comment
StephaneTrebel
left a comment
There was a problem hiding this comment.
Une chtite question, mais c'est mineur. LGTM
| } | ||
|
|
||
| async function setAdminPermisions() { | ||
| async function setTemplateGroupPermissions(groupName: string, permissions: readonly string[], templateName: string) { |
There was a problem hiding this comment.
question: permissions c'est une permission au sens défini ici ?
Ça me paraît louche que ce soit "simplement" un string[] à l'entrée comme ça 🤔
There was a problem hiding this comment.
Oui tout a fait, c'est une fonction plus generique
2 participants
Co-authered-by: William Phetsinorath william.phetsinorath@shikanime.studio
Signed-off-by: William Phetsinorath william.phetsinorath-open@interieur.gouv.fr