Fallback to Clojars for finding artifact version #268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Oct 8, 2019
src/refactor_nrepl/artifacts.clj
Outdated
| @@ -101,6 +101,14 @@ | |||
| (map #(vector (str group-id "/" %) nil)))) | |||
| group-ids))) | |||
|
|
|||
| (defn get-clojars-versions! | |||
| "Fetches all the versions of particular artifact from Clojars." | |||
| [for-artifact] | |||
There was a problem hiding this comment.
Me too, I followed the convention of the other function. Will update!
bbatsov
reviewed
Oct 8, 2019
| @@ -125,7 +133,8 @@ | |||
| (defn artifact-versions | |||
| [{:keys [artifact]}] | |||
| (->> (or (get @artifacts artifact) | |||
| (get-mvn-versions! artifact)) | |||
| (seq (get-mvn-versions! artifact)) | |||
There was a problem hiding this comment.
Might be a good idea to explain the behaviour of this function in the docstring.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had opened issue #267. This is the PR to solve the issue. This will use the Clojars API to fetch artifact versions if there are none to be found in Maven. The goal of this is to allow
cljr-update-project-dependency(ies)to work with Clojars-only libraries, such as clj-http, clj-time and aero.