Skip to content

Fallback on clojars when search.maven can't find artifact #267

Closed
@yannvanhalewyn

Description

@yannvanhalewyn

Search.maven can't find all the artifacts that are commonly used in clojure projects. Often these libraries can be found on Clojars. Examples of this are: aero, clj-http, clj-time, ... This results in cljr-update-project-dependency to throw the error cljr--get-versions-from-middleware: Empty version list received from middleware!. A secondary effect of this is that it stops walking all dependencies in a project when using cljr-update-project-dependencies when it hits one of these.

I'm happy to write a pull request for this. Before I do this I'd like to suggest what I'd like to change and see if this is a welcome contribution.

I would add a fallback to getting the version from clojars if non was returned from the search.maven API. Clojars has a straightforward API that returns artifact version. Examples:

https://clojars.org/api/artifacts/com.taoensso/timbre
https://clojars.org/api/artifacts/aero

It's pretty straightforward. Are there any problems I'm missing with this? Is this a welcome contribution?

Thanks for this great library I use actively every day!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions