Added the Krell REPL support

[dotemacs]

This change adds the support for Krell REPL.

Instead of having to pick a custom REPL and specifying a
cider-custom-cljs-repl-init-form, this is all now included. All the
user has to do is pick the REPL type, which in this case is krell.

I suspect that there might need to be issues to be considered:

• Is the way the "payload" is created, as in the require form, all on separate lines, is that OK? Or do you want it all on one line?
• If the above is OK, I'll move onto adding the documentation in the docs.

Please advise, thanks

[bbatsov]

From what I get krell can't define project types, so I'm guessing it should be defined as ClojureScript REPL type (e.g. the way figwheel is defined), not like something at the cider-jack-in level.

[dotemacs]

The test failures are lint failures, related to the code that my change does not touch:

cider-eval.el:347 -

cider/cider-eval.el

Line 347 in fdc8d69

(defconst cider-clojure-compilation-regexp (rx bol (or (eval cider-clojure-1.9-error)

cider.el:364 -

cider/cider.el

Line 364 in fdc8d69

(format cider-clojure-cli-parameters

[dotemacs]

From what I get krell can't define project types, so I'm guessing it should be defined as ClojureScript REPL type (e.g. the way figwheel is defined), not like something at the cider-jack-in level.

Hi @bbatsov, do you mean these:

• cider/cider.el

  Line 349 in fdc8d69

  ('krell (cider--resolve-command cider-clojure-cli-command))

• cider/cider.el

  Line 360 in fdc8d69

  ('krell cider-clojure-cli-global-options)

• cider/cider.el

  Line 381 in fdc8d69

  ('krell (cider--clojure-cli-parameters))

[bbatsov]

Yep. I think that only the cljs part the setup is actually needed (

cider/cider.el

Line 825 in fdc8d69

(defvar cider-cljs-repl-types

+ the cljs requirements check). That way you'll be able to pick krell regardless of your build tool.

[dotemacs]

Great, thanks for confirming!

[dotemacs]

Cleaned up the PR, please have a look.

A things to consider:

The way the require clause is provided, it isn't all on one line like it is for the other REPL types. Would you like that all flattened out to a single line? I'm talking about this https://github.com/clojure-emacs/cider/pull/2861/files#diff-00bd1ee3b6816bf7f502bc824ec4a6e9R834

[bbatsov]

The way the require clause is provided, it isn't all on one line like it is for the other REPL types. Would you like that all flattened out to a single line? I'm talking about this https://github.com/clojure-emacs/cider/pull/2861/files#diff-00bd1ee3b6816bf7f502bc824ec4a6e9R834

It's fine as it is.

Just update the changelog and add some docs about Krell (so that people know CIDER supports it now) and we're good to go.

[bbatsov]

@dotemacs ping :-)

[dotemacs]

Pong.

I’ll do it either today or this weekend.

Thanks

[bbatsov]

I'm planning to cut a new release soon, so I'll merge this as is. You can add the docs later.