Krell REPL type?

[dotemacs]

Is your feature request related to a problem? Please describe.

Krell https://github.com/vouch-opensource/krell has it's own REPL that needs to have dependencies loaded as per:
https://github.com/vouch-opensource/krell/wiki/nREPL-Piggieback-Cider

To use it, you can do the following:

(setq cider-custom-cljs-repl-init-form
      "(require '[clojure.java.io :as io]
         '[clojure.edn :as edn]
         '[cider.piggieback]
         '[krell.api :as krell]
         '[krell.repl])
(def config (edn/read-string (slurp (io/file \"build.edn\"))))
(krell/build config)
(apply cider.piggieback/cljs-repl (krell.repl/repl-env) (mapcat identity config))")

M-x cider-jack-in-cljs
When prompted for the REPL type provide custom.
Then once the connection to iPhone/Android simulator is established, the REPL starts to work.

Describe the solution you'd like

This is not a feature request, but rather a discussion.

Should there be a cider-cljs-repl-type of krell, so that the users can specify it and the above dependencies loaded in for them, much like it's done for figwheel, node, shadow...

What your thoughts/feels about this? Thanks

[dotemacs]

Clarification: "has it's own REPL" - the REPL is standard, but the extra dependencies are required.

[bbatsov]

Should there be a cider-cljs-repl-type of krell, so that the users can specify it and the above dependencies loaded in for them, much like it's done for figwheel, node, shadow...

I don't see why not.

[dotemacs]

Should there be a cider-cljs-repl-type of krell, so that the users can specify it and the above dependencies loaded in for them, much like it's done for figwheel, node, shadow...

I don't see why not.

Beautiful, I'll bite and take this. Thanks

[dotemacs]

I got the changes here, it works:

https://github.com/dotemacs/cider/tree/krell-repl

I want to have:

• some other CIDER users giving it a spin first
• tests

[KaterMikesch]

Great stuff. Any news on this? Help needed?

[dotemacs]

If you want to test it, that would be great @KaterMikesch

But otherwise it's pretty much done, feature wise.

It'll only be down to code style issues.

[dotemacs]

Created the PR: #2861

[KaterMikesch]

Manual installing this fork as described in "Hacking on Cider" is needed right? Let me see ...

[dotemacs]

@KaterMikesch that's right, thanks

[dotemacs]

I'm not sure what exactly you're doing, maybe list out every single step? I'm asking this because I tested it and had some other people look at it and it worked without an issue.

…

On Wed, Jun 17, 2020 at 2:37 PM KaterMikesch ***@***.***> wrote: Upon cider-jack-in-cljs I don't get asked which type of repl should be instantiated. Instead I get the following error message. What can that be? error in process sentinel: Could not start nREPL server: Error building classpath. Unable to compare versions for org.clojure/clojurescript: {:mvn/version "1.8.51", :deps/manifest :mvn} and {:git/url " https://github.com/clojure/clojurescript.git", :sha "7ca05517af2fdf698e5f1f23ac38dc45bb5d51e9", :deps/manifest :deps, :deps/root "/Users/axel/.gitlibs/libs/org.clojure/clojurescript/7ca05517af2fdf698e5f1f23ac38dc45bb5d51e9"} — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2841 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFGK4TUKERPGFPMC5LRULRXDII3ANCNFSM4M3QNVKQ> .

[KaterMikesch]

Unfortunately, I keep getting this error message:

[nREPL] Starting server via /usr/local/bin/clojure -Sdeps '{:deps {nrepl {:mvn/version "0.8.0-alpha1"} cider/piggieback {:mvn/version "0.5.0"} refactor-nrepl {:mvn/version "2.5.0"} cider/cider-nrepl {:mvn/version "0.25.3-SNAPSHOT"}}}' -m nrepl.cmdline --middleware '["refactor-nrepl.middleware/wrap-refactor", "cider.nrepl/cider-middleware", "cider.piggieback/wrap-cljs-repl"]'
error in process sentinel: nrepl-server-sentinel: Could not start nREPL server: Error building classpath. Unable to compare versions for org.clojure/clojurescript: {:mvn/version "1.8.51", :deps/manifest :mvn} and {:git/url "https://github.com/clojure/clojurescript.git", :sha "538dbe8133895c56f7da84609bcd696c85aa925c", :deps/manifest :deps, :deps/root "/Users/axel/.gitlibs/libs/org.clojure/clojurescript/538dbe8133895c56f7da84609bcd696c85aa925c"}

How can I solve this problem?

[dotemacs]

How can I solve this problem?

In order to solve this problem, it would be good to be able to reproduce it.

To reproduce it, try this: list out every single step that you're performing.

Also the contents of your project, preferably available publicly.