Skip to content

Conversation

@kazimuth
Copy link
Contributor

Description of Changes

SDK side of clockworklabs/SpacetimeDB#2636
Addresses #281

API

  • This is an API breaking change to the SDK

Requires SpacetimeDB PRs

clockworklabs/SpacetimeDB#2636

Testsuite

If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.

SpacetimeDB branch name: jgilles/on-unhandled-reducer-error

Testing

  • Add a test that this works to the regression-tests example module

@kazimuth kazimuth requested a review from rekhoff April 18, 2025 20:17
Copy link
Contributor

@rekhoff rekhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generated code matches what is expected coming out of changes in clockworklabs/SpacetimeDB#2636.
Regression tests are clear and understandable.
Approved.

@kazimuth kazimuth merged commit 8c1b4a9 into master Apr 23, 2025
6 checks passed
@kazimuth kazimuth deleted the jgilles/on-unhandled-reducer-error branch April 23, 2025 20:50
bfops pushed a commit that referenced this pull request Jul 28, 2025
## Description of Changes
SDK side of clockworklabs/SpacetimeDB#2636
Addresses
#281

## API

 - [ ] This is an API breaking change to the SDK

## Requires SpacetimeDB PRs
clockworklabs/SpacetimeDB#2636

## Testsuite
*If you would like to run the your SDK changes in this PR against a
specific SpacetimeDB branch, specify that here. This can be a branch
name or a link to a PR.*

SpacetimeDB branch name: jgilles/on-unhandled-reducer-error

## Testing

- [ ] Add a test that this works to the regression-tests example module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants