Implement OnUnhandledReducerError in C# #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
rekhoff
approved these changes
Apr 21, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Looks good, and tracks with our previous discussions.
I'm good with the summary comment as-is, but if you where looking for an alternative,
Register a callback to be called when a reducer with no registered callbacks is invoked.
might be slightly more accurate. The double use of the words "register" and "callback" does make it a bit confusing, but it is a factual statement :)
I'm good with moving forward with what you've got here, and it fulfills the goal defined in #2513
kazimuth
added a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Apr 23, 2025
## Description of Changes SDK side of clockworklabs/SpacetimeDB#2636 Addresses #281 ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#2636 ## Testsuite *If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.* SpacetimeDB branch name: jgilles/on-unhandled-reducer-error ## Testing - [ ] Add a test that this works to the regression-tests example module
2 tasks
bfops
pushed a commit
that referenced
this pull request
Jul 17, 2025
## Description of Changes SDK side of #2636 Addresses clockworklabs/com.clockworklabs.spacetimedbsdk#281 ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs #2636 ## Testsuite *If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.* SpacetimeDB branch name: jgilles/on-unhandled-reducer-error ## Testing - [ ] Add a test that this works to the regression-tests example module
bfops
pushed a commit
to clockworklabs/com.clockworklabs.spacetimedbsdk
that referenced
this pull request
Jul 28, 2025
## Description of Changes SDK side of clockworklabs/SpacetimeDB#2636 Addresses #281 ## API - [ ] This is an API breaking change to the SDK ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#2636 ## Testsuite *If you would like to run the your SDK changes in this PR against a specific SpacetimeDB branch, specify that here. This can be a branch name or a link to a PR.* SpacetimeDB branch name: jgilles/on-unhandled-reducer-error ## Testing - [ ] Add a test that this works to the regression-tests example module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Addresses clockworklabs/com.clockworklabs.spacetimedbsdk#281
If someone has a better idea for the doc comment I'd appreciate it
API and ABI breaking changes
Expected complexity level and risk
1
Testing
Testing is happening in the C# SDK