Skip to content

Comments

Replay: handle multiple column types in the same table changing#3893

Merged
gefjon merged 3 commits intophoebe/replay-handle-delete-of-nonexistent-tablefrom
phoebe/replay-multiple-changed-col-types
Dec 17, 2025
Merged

Replay: handle multiple column types in the same table changing#3893
gefjon merged 3 commits intophoebe/replay-handle-delete-of-nonexistent-tablefrom
phoebe/replay-multiple-changed-col-types

Conversation

@gefjon
Copy link
Contributor

@gefjon gefjon commented Dec 16, 2025

Description of Changes

Based on #3892 ; begin reviewing at 21b3d1d.

I'll expand on this description later.

API and ABI breaking changes

N/a.

Expected complexity level and risk

3 - we already rewrote this path once or twice before and thought we'd fixed it.

Testing

  • Manually replayed commitlog which contained an automigration that changed multiple column types from the same table.

@gefjon gefjon force-pushed the phoebe/replay-handle-delete-of-nonexistent-table branch from 8513a43 to 9edc066 Compare December 17, 2025 16:53
@gefjon gefjon force-pushed the phoebe/replay-multiple-changed-col-types branch from 21b3d1d to 63e0692 Compare December 17, 2025 16:57
@gefjon
Copy link
Contributor Author

gefjon commented Dec 17, 2025

Rebased onto updated #3892 .

@gefjon gefjon merged commit d2dbc5b into phoebe/replay-handle-delete-of-nonexistent-table Dec 17, 2025
20 of 22 checks passed
aasoni pushed a commit that referenced this pull request Feb 5, 2026
Based on #3892 ; begin reviewing at 21b3d1d.

I'll expand on this description later.

N/a.

3 - we already rewrote this path once or twice before and thought we'd
fixed it.

- [x] Manually replayed commitlog which contained an automigration that
changed multiple column types from the same table.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants