Don't error during replay when deleting a table with no in-memory instance#3892
Merged
gefjon merged 2 commits intophoebe/ignore-st-meta-insertsfrom Dec 17, 2025
Conversation
kim
approved these changes
Dec 16, 2025
Centril
approved these changes
Dec 16, 2025
1 task
gefjon
force-pushed
the
phoebe/ignore-st-meta-inserts
branch
from
3539a19 to
139dc8b
Compare
…tance Prior to this commit, we treated it as an error (in fact a panic, prior to an earlier commit of mine today) when deleting a table during replay which didn't have an in-memory instace. This should not have been an error, as it's not problematic, and it can occur in valid commitlogs when a table is initially empty and is never used prior to its deletion. With this commit, don't error.
gefjon
force-pushed
the
phoebe/replay-handle-delete-of-nonexistent-table
branch
from
8513a43 to
9edc066
Compare
Contributor
Author
|
Rebased onto updated #3891 . |
# Description of Changes Based on #3892 ; begin reviewing at 21b3d1d. I'll expand on this description later. # API and ABI breaking changes N/a. # Expected complexity level and risk 3 - we already rewrote this path once or twice before and thought we'd fixed it. # Testing - [x] Manually replayed commitlog which contained an automigration that changed multiple column types from the same table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Based on #3891 . Begin reviewing from commit 4370b69.
Prior to this commit, we treated it as an error (in fact a panic, prior to an earlier commit of mine today) when deleting a table during replay which didn't have an in-memory instace. This should not have been an error, as it's not problematic, and it can occur in valid commitlogs when a table is initially empty and is never used prior to its deletion.
With this commit, don't error.
API and ABI breaking changes
N/a
Expected complexity level and risk
1
Testing