SQL smoketests for views #3616
Merged
SQL smoketests for views #3616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
commented
Nov 10, 2025
Co-authored-by: Shubham Mishra <shivam828787@gmail.com> Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
Co-authored-by: Shubham Mishra <shivam828787@gmail.com> Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
# Description of Changes Updates views atomically on commit, but before downgrading to a read-only transaction for subscription evaluation. What this patch does: 1. Renames `ViewId` to `ViewFnPtr` 2. Renames `ViewDatabaseId` to `ViewId` 3. Removes the `module_rx` module watcher from the subscription manager 4. Refactors read sets to only track table scans (index key tracking will be added later) 5. Drops read sets and removes rows from `st_view_sub` when dropping a view in an auto-migrate 6. Re-evaluates and updates views (`call_views_with_tx`) from `call_reducer_with_tx` for any view whose read set overlaps with the reducer's write set 7. Does the same for sql dml # API and ABI breaking changes None # Expected complexity level and risk 3 It's a bit of a messy diff. # Testing - [x] Integrate with #3616 --------- Signed-off-by: joshua-spacetime <josh@clockworklabs.io> Co-authored-by: Shubham Mishra <shivam828787@gmail.com>
Closed
joshua-spacetime
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch tests calling, updating, and materialization of views through the SQL api.
API and ABI breaking changes
None
Expected complexity level and risk
1.5
Testing
Smoketests