Skip to content

Conversation

@joshua-spacetime
Copy link
Collaborator

@joshua-spacetime joshua-spacetime commented Nov 10, 2025

Description of Changes

Updates views atomically on commit, but before downgrading to a read-only transaction for subscription evaluation.

What this patch does:

  1. Renames ViewId to ViewFnPtr
  2. Renames ViewDatabaseId to ViewId
  3. Removes the module_rx module watcher from the subscription manager
  4. Refactors read sets to only track table scans (index key tracking will be added later)
  5. Drops read sets and removes rows from st_view_sub when dropping a view in an auto-migrate
  6. Re-evaluates and updates views (call_views_with_tx) from call_reducer_with_tx for any view whose read set overlaps with the reducer's write set
  7. Does the same for sql dml

API and ABI breaking changes

None

Expected complexity level and risk

3

It's a bit of a messy diff.

Testing

joshua-spacetime and others added 8 commits November 10, 2025 16:38
Co-authored-by: Shubham Mishra <shivam828787@gmail.com>
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
Co-authored-by: Shubham Mishra <shivam828787@gmail.com>
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
@joshua-spacetime joshua-spacetime linked an issue Nov 11, 2025 that may be closed by this pull request
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Nov 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 11, 2025
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Nov 11, 2025
Merged via the queue into master with commit 0de8910 Nov 11, 2025
25 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/update-views branch November 11, 2025 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make views queryable

3 participants