Skip to content

Fix issue with row id for non primary key tables #3603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cloutiertyler merged 2 commits into from
Nov 7, 2025
Merged

Fix issue with row id for non primary key tables #3603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfaee85
Fix issue with row id for non primary key tables
aasoni Nov 7, 2025
c4a4fb8
Merge branch 'master' into alessandro/bugfix/typescript-sdk-issue-wit…
cloutiertyler Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion crates/bindings-typescript/src/sdk/db_connection_impl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ export class DbConnectionImpl<
const reader = new BinaryReader(buffer);
const rows: Operation[] = [];
const rowType = this.#remoteModule.tables[tableName]!.rowType;
let previousOffset = 0;
const primaryKeyInfo =
this.#remoteModule.tables[tableName]!.primaryKeyInfo;
while (reader.remaining > 0) {
Expand All @@ -305,11 +306,12 @@ export class DbConnectionImpl<
);
} else {
// Get a view of the bytes for this row.
const rowBytes = buffer.subarray(0, reader.offset);
const rowBytes = buffer.subarray(previousOffset, reader.offset);
// Convert it to a base64 string, so we can use it as a map key.
const asBase64 = fromByteArray(rowBytes);
rowId = asBase64;
}
previousOffset = reader.offset;

rows.push({
type,
Expand Down
Loading