Fix issue with row id for non primary key tables #3603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
approved these changes
Nov 7, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
I tested this with Alessandro
…h-non-primary-key-tables
bfops
pushed a commit
that referenced
this pull request
Nov 8, 2025
#3603) # Description of Changes When computing rowId for non primary key tables the typescript sdk incorrectly used the entire data buffer. This resulted in rowIds being incorrect when multiple rows were present within an update. # Expected complexity level and risk 1 # Testing Tested this in the context of developing the collaborator feature on the spacetime.com website. Without this change, updates to tables without primary keys were sometimes not applied to the client cache. With this update no further issues were observed. Co-authored-by: Tyler Cloutier <cloutiertyler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
When computing rowId for non primary key tables the typescript sdk incorrectly used the entire data buffer.
This resulted in rowIds being incorrect when multiple rows were present within an update.
Expected complexity level and risk
1
Testing
Tested this in the context of developing the collaborator feature on the spacetime.com website.
Without this change, updates to tables without primary keys were sometimes not applied to the client cache.
With this update no further issues were observed.