Remove the dependency on git ls-files from cli/build.rs #3568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We technically don't need to `git ls-files` when getting the CLI templates because when we compile the release builds we work with a clean git clone, thus it's unlikely any untracked files will be created in the templates directory.
drogus
changed the title
bfops
added
release-any
drogus
force-pushed
the
drogus/remove-git-ls-files-from-build-rs
branch
from
303a65e to
76ec0a1
Compare
gefjon
approved these changes
Nov 24, 2025
1 task
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
… (#3741) # Description of Changes This reverts commit 53f692d (#3568) That PR broke the build if any of the directories used as templates are not clean. It spammed lots of errors like: ``` error: `C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/client.pdb` wasn't a utf-8 file --> C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/client.pdb:0:49 | error: `C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/ref/client.dll` wasn't a utf-8 file --> C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/ref/client.dll:0:3 | error: `C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/refint/client.dll` wasn't a utf-8 file --> C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/refint/client.dll:0:3 ``` # API and ABI breaking changes None. # Expected complexity level and risk 1 # Testing - [x] `cargo build` passes on my repo now, which it wasn't before this commit Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We technically don't need to
git ls-fileswhen getting the CLI templates because when we compile the release builds we work with a clean git clone, thus it's unlikely any untracked files will be created in the templates directory.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing