Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Nov 24, 2025

Description of Changes

This reverts commit 53f692d (#3568)

That PR broke the build if any of the directories used as templates are not clean. It spammed lots of errors like:

error: `C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/client.pdb` wasn't a utf-8 file
 --> C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/client.pdb:0:49
  |

error: `C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/ref/client.dll` wasn't a utf-8 file
 --> C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/ref/client.dll:0:3
  |

error: `C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/refint/client.dll` wasn't a utf-8 file
 --> C:\Users\boppy\clockwork\SpacetimeDB\crates\cli/.templates/parent_parent_sdks_csharp_examples~_quickstart-chat_client/obj~/Debug/net8.0/refint/client.dll:0:3

API and ABI breaking changes

None.

Expected complexity level and risk

1

Testing

  • cargo build passes on my repo now, which it wasn't before this commit

@bfops bfops requested a review from jdetter November 24, 2025 18:07
@gefjon
Copy link
Contributor

gefjon commented Nov 24, 2025

In https://github.com/clockworklabs/SpacetimeDB/actions/runs/19641259888/job/56245061387 , I'm seeing a dirty worktree in CI. This is concerning to me; how can the worktree not be clean in our CI runner?

I would also like to know if we see any alternative path to reducing or removing our usage of git in build scripts, given the problems it's caused both in Git builds and among our users.

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that I hit the same flood of errors on windows, @drogus could you give this another shot when you get a chance?

@bfops
Copy link
Collaborator Author

bfops commented Nov 24, 2025

In https://github.com/clockworklabs/SpacetimeDB/actions/runs/19641259888/job/56245061387 , I'm seeing a dirty worktree in CI. This is concerning to me; how can the worktree not be clean in our CI runner?

Because the CI had the audacity to build and test the quickstart-chat module before trying to build the CLI.

I would also like to know if we see any alternative path to reducing or removing our usage of git in build scripts, given the problems it's caused both in Git builds and among our users.

Agreed. Created Remove git dependency in CLI build.rs.

@bfops bfops added this pull request to the merge queue Nov 24, 2025
Merged via the queue into master with commit 5113488 Nov 24, 2025
27 of 28 checks passed
@bfops bfops deleted the bfops/revert-3568 branch December 2, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants