-
Notifications
You must be signed in to change notification settings - Fork 663
Integrate tools/upgrade-version into cargo and expand
#3308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this on my Windows 11 machine and it appears to work just fine as well. Thanks Zeke!
Q: Do we remove the previous script that we were using to do this in favor of this or do you want to just leave it?
Isn't |
yes you caught my stupid question before I had time to delete it, sorry I thought it was a Python script before but obviously we've just updated it here 😅 |
# Description of Changes * Make sure the user provides at least one of `--rust-and-cli`, `--typescript`, or `--csharp`, since providing none of them is a no-op as of #3308 * Do a semver-parsing of the arg before doing anything, and use that parsed version everywhere * Consolidate some version strings that we were computing in a few places # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [x] Running `cargo bump-versions 1.5.0 --typescript --rust-and-cli --csharp` only shows a diff in the change dates --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
# Description of Changes * Make sure the user provides at least one of `--rust-and-cli`, `--typescript`, or `--csharp`, since providing none of them is a no-op as of #3308 * Do a semver-parsing of the arg before doing anything, and use that parsed version everywhere * Consolidate some version strings that we were computing in a few places # API and ABI breaking changes None # Expected complexity level and risk 1 # Testing - [x] Running `cargo bump-versions 1.5.0 --typescript --rust-and-cli --csharp` only shows a diff in the change dates --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Description of Changes
tools/upgrade-versioncan now be run via justcargo bump-versions.By default, it does nothing. You must now specify at least one of:
--rust-and-cli,--typescript, or--csharp.This also now bumps the
StdbModule.csprojversion indemo/Blackholio. I'm not sure if that's desired or not, but it was still at1.0.0which doesn't seem quite right.API and ABI breaking changes
None
Expected complexity level and risk
2
Testing
cargo bump-versions 1.5.0 --rust-and-clicargo bump-versions 1.5.0 --typescriptcargo bump-versions 1.5.0 --csharp