Skip to content

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Oct 7, 2025

Description of Changes

It turns out that cargo automatically uses the latest semver-compatible versions of dependencies, which is not what we expected. tl;dr specifying 1.5.0 actually means >=1.5.0 <2.0.0, but we actually intend 1.5.*.

This PR updates our upgrade-version tool, and re-runs it to fix the dep versions.

API and ABI breaking changes

None.

Expected complexity level and risk

1

Testing

  • I ran cargo bump-versions 1.5.0 --rust-and-cli to regenerate the other committed files.

@bfops bfops marked this pull request as ready for review October 7, 2025 17:47
Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions on this

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, if we end up sending out a 1.5.X patch version let's try to get this in as well. Thanks @bfops 🙏

@bfops bfops enabled auto-merge October 7, 2025 18:49
@bfops bfops added this pull request to the merge queue Oct 7, 2025
auto-merge was automatically disabled October 7, 2025 19:09

Pull Request is not mergeable

Merged via the queue into master with commit e3d2dfd Oct 7, 2025
25 of 26 checks passed
@bfops bfops deleted the bfops/dep-versions branch October 9, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants