-
Notifications
You must be signed in to change notification settings - Fork 663
Fix Rust dep versions #3369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Rust dep versions #3369
Conversation
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions on this
jdetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, if we end up sending out a 1.5.X patch version let's try to get this in as well. Thanks @bfops 🙏
Pull Request is not mergeable
Description of Changes
It turns out that cargo automatically uses the latest semver-compatible versions of dependencies, which is not what we expected. tl;dr specifying
1.5.0actually means>=1.5.0 <2.0.0, but we actually intend1.5.*.This PR updates our
upgrade-versiontool, and re-runs it to fix the dep versions.API and ABI breaking changes
None.
Expected complexity level and risk
1
Testing
cargo bump-versions 1.5.0 --rust-and-clito regenerate the other committed files.