Skip to content

Add counters for client connections spawned and aborted. #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdt merged 2 commits into from
May 15, 2025
Merged

Add counters for client connections spawned and aborted. #2741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c9ce94
Add counters for client connections spawned and aborted.
jsdt May 15, 2025
7e89e83
Merge branch 'master' into jsdt/ws-connection-stats
jsdt May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/core/src/client/client_connection.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ impl ClientConnection {
let Ok(fut) = fut_rx.await else { return };

let _gauge_guard = WORKER_METRICS.connected_clients.with_label_values(&db).inc_scope();
WORKER_METRICS.ws_clients_spawned.with_label_values(&db).inc();
scopeguard::defer!(WORKER_METRICS.ws_clients_aborted.with_label_values(&db).inc());

fut.await
})
Expand Down
10 changes: 10 additions & 0 deletions crates/core/src/worker_metrics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ metrics_group!(
#[labels(database_identity: Identity)]
pub connected_clients: IntGaugeVec,

#[name = spacetime_worker_ws_clients_spawned]
#[help = "Number of new ws client connections spawned. Counted after any on_connect reducers are run."]
#[labels(database_identity: Identity)]
pub ws_clients_spawned: IntGaugeVec,

#[name = spacetime_worker_ws_clients_aborted]
#[help = "Number of ws client connections aborted"]
#[labels(database_identity: Identity)]
pub ws_clients_aborted: IntGaugeVec,

#[name = spacetime_websocket_requests_total]
#[help = "The cumulative number of websocket request messages"]
#[labels(replica_id: u64, protocol: str)]
Expand Down
Loading