Add counters for client connections spawned and aborted. #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
approved these changes
May 15, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
I'm approving this because we'd like to get it into Ryan's new baseline test for the technical test. The risk is very low as it is only metrics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This adds two new metrics to track how often websocket clients connect and disconnect (
spacetime_worker_ws_clients_spawned, andspacetime_worker_ws_clients_aborted).Note that this isn't tracking at the tcp connection level, rather it only counts clients that have gone through any client lifecycle reducers.
Adding a metric for rejected clients (meaning the on_connect reducer failed) in the future could be useful.
API and ABI breaking changes
This is purely a metrics change.