Fixed compile errors and warnings on Windows #2646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
force-pushed
the
tyler/fix-windows
branch
from
01a1d0e to
1e761c9
Compare
Collaborator
|
Should we add a version of the |
|
|
Centril
approved these changes
May 21, 2025
Collaborator
|
(I still think we should add a version of the |
cloutiertyler
force-pushed
the
tyler/fix-windows
branch
from
1e761c9 to
6a23bc6
Compare
cloutiertyler
added a commit
that referenced
this pull request
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
SpacetimeDB doesn't actually compile on Windows because of bit rot of our various
cfgflags. This fixes that issue.It further fixes warnings caused by unused variables that are
cfg'd out.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
No testing beyond automated testing. No functionality should be changed.