Use spacetimedb-standalone to get schema for spacetime generate #2644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
coolreader18
force-pushed
the
noa/shell-out-for-schema
branch
4 times, most recently
from
0cb9645 to
c9f886b
Compare
coolreader18
force-pushed
the
noa/shell-out-for-schema
branch
3 times, most recently
from
01d902c to
cafb0d8
Compare
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
Seems quite reasonable, and minimal. I like this quite a bit. Two things before I approve:
- Left one comment that we should mark the new command as unstable
- Need to fix the private repo:
#14 66.46 Caused by:
#14 66.46 0: failed to spawn /build/public/target/debug/spacetimedb-standalone
#14 66.46 1: No such file or directory (os error 2)
#14 66.47 Error: failed to generate control-client
cafb0d8 to
9aed4cb
Compare
coolreader18
force-pushed
the
noa/shell-out-for-schema
branch
from
9aed4cb to
a3f59eb
Compare
Collaborator
Author
|
Apologies for the rebase; there was a big conflict with #2593 and it didn't really make sense to do a merge. |
cloutiertyler
approved these changes
Apr 29, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
I'm approving this. Note that I spoke with Noa and we can't print the unstable warning in standalone extract-schema, because it'll be printed from spacetime generate
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
In preparation for adding another host type, I realized it would make sense to have it so we don't have to compile huge runtimes for spacetimedb-cli in addition to spacetimedb-standalone. Now,
spacetime generateshells out to spacetimedb-standalone, which useshost_controller.check_module_validity()to load the module and get theModuleDef.Expected complexity level and risk
2: Introducing another way that the binaries interact with each other, but this is altogether pretty small and straightforward.
Testing
spacetime generatestill works.