Split client codegen out into its own crate #2593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Collaborator
|
I don't have any input here, feel free to move this one forward without me 👍 |
coolreader18
force-pushed
the
noa/split-generate-crate
branch
from
04044a1 to
7a75667
Compare
bfops
approved these changes
Apr 25, 2025
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
Okay, the code LGTM! As you said, if the existing tests pass and the snapshots are unchanged, this seems like it should be good.
Also TIL about git diff --color-moved.
cloutiertyler
approved these changes
Apr 25, 2025
Contributor
cloutiertyler
left a comment
cloutiertyler
left a comment
There was a problem hiding this comment.
CODEOWNERS change LGTM
coolreader18
force-pushed
the
noa/split-generate-crate
branch
from
fbcac0e to
f8193f5
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
4 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This is something I've had a branch for for a while, and now that #2244 is merged I can open it. This makes the codeowners situation simpler, and also lets us put the codegen snapshot tests directly with the codegen crate instead of as integration tests using the Rust api of the CLI.
I moved the
Lang::{format_files,clap_value}functions off of the trait because those aren't really related to codegen, and fit better in thespacetimedb_cli::tasksmodule and inlined intoto_possible_valuerespectively.API and ABI breaking changes
Expected complexity level and risk
1: if you review with
git diff master --color-moved, you'll see that most of this is just very straightforward code movement.Testing
n/a; no new behavior and the codegen snapshot tests still pass.